Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753344AbaAZVJQ (ORCPT ); Sun, 26 Jan 2014 16:09:16 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:35863 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752397AbaAZVJM (ORCPT ); Sun, 26 Jan 2014 16:09:12 -0500 Date: Sun, 26 Jan 2014 22:09:07 +0100 From: Pavel Machek To: Mark Brown Cc: Tomasz Figa , Alan Cox , Tushar Behera , Russell King - ARM Linux , lkml , linux-serial , linux-samsung-soc , jslaby , Greg Kroah-Hartman , Ben Dooks Subject: Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe Message-ID: <20140126210907.GB7246@Nokia-N900> References: <1390208555-27770-1-git-send-email-tushar.behera@linaro.org> <1390208555-27770-2-git-send-email-tushar.behera@linaro.org> <20140120100530.GY15937@n2100.arm.linux.org.uk> <20140123180423.1a62611a@www.etchedpixels.co.uk> <20140123184022.GC11727@sirena.org.uk> <52E163DC.1090002@samsung.com> <20140123193633.GG11727@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140123193633.GG11727@sirena.org.uk> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 2014-01-23 19:36:33, Mark Brown wrote: > On Thu, Jan 23, 2014 at 07:47:56PM +0100, Tomasz Figa wrote: > > On 23.01.2014 19:40, Mark Brown wrote: > > > >We'd need to leave it user selectable rather than enabling it for ARM, > > >the whole reason this got noticed is that people are trying to build > > >kernels that support a wider range of devices for ARM. > > > What about making it depend on !MULTIPLATFORM and enabled by default? > > That'd work, but if we're doing that then substituting in the dynamic > assignment only when we hit a collision seems smoother and more general. That seems like a mess. I had enough fun debugging "WTF is going on with my serials" as is... Plus... collision can happen at runtime when you insert BT CF card... at that point it is too late to reassign. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/