Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753242AbaAZX3u (ORCPT ); Sun, 26 Jan 2014 18:29:50 -0500 Received: from perceval.ideasonboard.com ([95.142.166.194]:45211 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753040AbaAZX3t (ORCPT ); Sun, 26 Jan 2014 18:29:49 -0500 From: Laurent Pinchart To: Richard Weinberger Cc: rui.zhang@intel.com, eduardo.valentin@ti.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, horms@verge.net.au, laurent.pinchart+renesas@ideasonboard.com Subject: Re: [PATCH 2/2] thermal,rcar_thermal: Add dependency on HAS_IOMEM Date: Mon, 27 Jan 2014 00:30:37 +0100 Message-ID: <1827069.1uKx343yy0@avalon> User-Agent: KMail/4.11.5 (Linux/3.10.25-gentoo; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1390688954-4940-1-git-send-email-richard@nod.at> References: <1390688954-4940-1-git-send-email-richard@nod.at> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Richard, Thank you for the patch. On Saturday 25 January 2014 23:29:14 Richard Weinberger wrote: > Commit beeb5a1e (thermal: rcar-thermal: Enable driver compilation with > COMPILE_TEST) broke build on archs wihout io memory. > > On archs like S390 or um this driver cannot build nor work. > Make it depend on HAS_IOMEM to bypass build failures. > > drivers/thermal/rcar_thermal.c:404: undefined reference to > `devm_ioremap_resource' drivers/thermal/rcar_thermal.c:426: undefined > reference to `devm_ioremap_resource' > > Signed-off-by: Richard Weinberger > --- > drivers/thermal/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 35c0664..88efa8f 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -136,6 +136,7 @@ config SPEAR_THERMAL > config RCAR_THERMAL > tristate "Renesas R-Car thermal driver" > depends on ARCH_SHMOBILE || COMPILE_TEST > + depends on HAS_IO_MEM Shouldn't that be HAS_IOMEM ? > help > Enable this to plug the R-Car thermal sensor driver into the Linux > thermal framework. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/