Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753450AbaA0AFG (ORCPT ); Sun, 26 Jan 2014 19:05:06 -0500 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:36758 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753173AbaA0AFE (ORCPT ); Sun, 26 Jan 2014 19:05:04 -0500 Date: Mon, 27 Jan 2014 00:04:26 +0000 From: Alan Cox To: Pavel Machek Cc: Mark Brown , Tomasz Figa , Tushar Behera , Russell King - ARM Linux , lkml , linux-serial , linux-samsung-soc , jslaby , Greg Kroah-Hartman , Ben Dooks Subject: Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe Message-ID: <20140127000426.6027cdd5@www.etchedpixels.co.uk> In-Reply-To: <20140126210907.GB7246@Nokia-N900> References: <1390208555-27770-1-git-send-email-tushar.behera@linaro.org> <1390208555-27770-2-git-send-email-tushar.behera@linaro.org> <20140120100530.GY15937@n2100.arm.linux.org.uk> <20140123180423.1a62611a@www.etchedpixels.co.uk> <20140123184022.GC11727@sirena.org.uk> <52E163DC.1090002@samsung.com> <20140123193633.GG11727@sirena.org.uk> <20140126210907.GB7246@Nokia-N900> X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.20; x86_64-pc-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEWysKsSBQMIAwIZCwj///8wIhxoRDXH9QHCAAABeUlEQVQ4jaXTvW7DIBAAYCQTzz2hdq+rdg494ZmBeE5KYHZjm/d/hJ6NfzBJpp5kRb5PHJwvMPMk2L9As5Y9AmYRBL+HAyJKeOU5aHRhsAAvORQ+UEgAvgddj/lwAXndw2laEDqA4x6KEBhjYRCg9tBFCOuJFxg2OKegbWjbsRTk8PPhKPD7HcRxB7cqhgBRp9Dcqs+B8v4CQvFdqeot3Kov6hBUn0AJitrzY+sgUuiA8i0r7+B3AfqKcN6t8M6HtqQ+AOoELCikgQSbgabKaJW3kn5lBs47JSGDhhLKDUh1UMipwwinMYPTBuIBjEclSaGZUk9hDlTb5sUTYN2SFFQuPe4Gox1X0FZOufjgBiV1Vls7b+GvK3SU4wfmcGo9rPPQzgIabfj4TYQo15k3bTHX9RIw/kniir5YbtJF4jkFG+dsDK1IgE413zAthU/vR2HVMmFUPIHTvF6jWCpFaGw/A3qWgnbxpSm9MSmY5b3pM1gvNc/gQfwBsGwF0VCtxZgAAAAASUVORK5CYII= Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 26 Jan 2014 22:09:07 +0100 Pavel Machek wrote: > On Thu 2014-01-23 19:36:33, Mark Brown wrote: > > On Thu, Jan 23, 2014 at 07:47:56PM +0100, Tomasz Figa wrote: > > > On 23.01.2014 19:40, Mark Brown wrote: > > > > > >We'd need to leave it user selectable rather than enabling it for ARM, > > > >the whole reason this got noticed is that people are trying to build > > > >kernels that support a wider range of devices for ARM. > > > > > What about making it depend on !MULTIPLATFORM and enabled by default? > > > > That'd work, but if we're doing that then substituting in the dynamic > > assignment only when we hit a collision seems smoother and more general. > > That seems like a mess. I had enough fun debugging "WTF is > going on with my serials" as is... > > Plus... collision can happen at runtime when you insert > BT CF card... at that point it is too late to reassign. Agreed entirely - you want predictability here, plus making it happen by magic is going to do the nut of anyone trying to figure out why kernel A works on their platform and kernel B doesn't. It needs to be something you choose to turn on as compatibility, like old sysfs files and so forth. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/