Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753639AbaA0JVM (ORCPT ); Mon, 27 Jan 2014 04:21:12 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:44102 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751425AbaA0JVJ (ORCPT ); Mon, 27 Jan 2014 04:21:09 -0500 Message-ID: <52E62500.7090604@ti.com> Date: Mon, 27 Jan 2014 14:51:04 +0530 From: George Cherian User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Sergei Shtylyov , CC: , , Subject: Re: [PATCH 1/3] usb: musb: musb_host: Enable ISOCH IN handling for AM335x host References: <1390572895-26428-1-git-send-email-george.cherian@ti.com> <1390572895-26428-2-git-send-email-george.cherian@ti.com> <52E2A643.6050209@cogentembedded.com> In-Reply-To: <52E2A643.6050209@cogentembedded.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/24/2014 11:13 PM, Sergei Shtylyov wrote: > Hello. > > On 24-01-2014 18:14, George Cherian wrote: > >> Enable the isochrounous IN handling for AM335x HOST. >> Reprogram CPPI to receive consecutive ISOCH frames in the same URB. > > Sigh, I knew CPPI ISO path was broken for years but didn't have > time to fix it. :-( > >> Signed-off-by: George Cherian >> --- git rebase >> drivers/usb/musb/musb_host.c | 29 ++++++++++++++++++++++++++--- >> 1 file changed, 26 insertions(+), 3 deletions(-) > >> diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c >> index ed45572..5b6482c 100644 >> --- a/drivers/usb/musb/musb_host.c >> +++ b/drivers/usb/musb/musb_host.c >> @@ -1689,9 +1689,11 @@ void musb_host_rx(struct musb *musb, u8 epnum) >> | MUSB_RXCSR_H_AUTOREQ >> | MUSB_RXCSR_AUTOCLEAR >> | MUSB_RXCSR_RXPKTRDY); >> + > > Not needed. > >> musb_writew(hw_ep->regs, MUSB_RXCSR, val); >> >> -#if defined(CONFIG_USB_INVENTRA_DMA) || defined(CONFIG_USB_UX500_DMA) >> +#if defined(CONFIG_USB_INVENTRA_DMA) || >> defined(CONFIG_USB_UX500_DMA) || \ >> + defined(CONFIG_USB_TI_CPPI41_DMA) > > The DaVinci CPPI 3.0 should probably also be included here... > Should'nt that be a separate patch as this one is specific to AM335X. >> if (usb_pipeisoc(pipe)) { >> struct usb_iso_packet_descriptor *d; >> >> @@ -1706,8 +1708,28 @@ void musb_host_rx(struct musb *musb, u8 epnum) >> >> if (++qh->iso_idx >= urb->number_of_packets) >> done = true; >> - else >> + else { > > If you're making the *else* arm use {}, you should make all the > other arms of *if* statement also have them -- see > Documentation/CodingStyle. Will fix in v2!!! > > WBR, Sergei > -- -George -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/