Message-ID: <52E65172.6070809@unitn.it>
Date: Mon, 27 Jan 2014 13:30:42 +0100
From: Luca Abeni <luca.abeni@unitn.it>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.2.0
MIME-Version: 1.0
To: Henrik Austad <henrik@austad.us>, Juri Lelli <juri.lelli@gmail.com>
CC: peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com,
        rostedt@goodmis.org, oleg@redhat.com, fweisbec@gmail.com,
        darren@dvhart.com, johan.eker@ericsson.com, p.faure@akatech.ch,
        linux-kernel@vger.kernel.org, claudio@evidence.eu.com,
        michael@amarulasolutions.com, fchecconi@gmail.com,
        tommaso.cucinotta@sssup.it, nicola.manica@disi.unitn.it,
        dhaval.giani@gmail.com, hgu1972@gmail.com, paulmck@linux.vnet.ibm.com,
        raistlin@linux.it, insop.song@gmail.com, liming.wang@windriver.com,
        jkacur@redhat.com, harald.gustafsson@ericsson.com,
        vincent.guittot@linaro.org, bruce.ashfield@windriver.com,
        linux-doc@vger.kernel.org, rob@landley.net
Subject: Re: [PATCH] sched/deadline: Add sched_dl documentation
References: <1390821615-23247-1-git-send-email-juri.lelli@gmail.com> <20140127115316.GA16595@austad.us>
In-Reply-To: <20140127115316.GA16595@austad.us>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

Hi Henrik,

On 01/27/2014 12:53 PM, Henrik Austad wrote:
[...]
>> + In more details, the CBS algorithm assigns scheduling deadlines to
>> + tasks in the following way:
>> +
>> +  - Each SCHED_DEADLINE task is characterised by the "runtime",
>> +    "deadline", and "period" parameters;
>> +
>> +  - The state of the task is described by a "scheduling deadline", and
>> +    a "current runtime". These two parameters are initially set to 0;
>> +
>> +  - When a SCHED_DEADLINE task wakes up (becomes ready for execution),
>> +    the scheduler checks if
>> +
>> +                    current runtime                runtime
>> +         ---------------------------------- > ----------------
>> +         scheduling deadline - current time         period
>> +
>> +    then, if the scheduling deadline is smaller than the current time, or
>> +    this condition is verified, the scheduling deadline and the
>> +    current budget are re-initialised as
>
> Current runtime: time spent running _this_ period? or is _remaining_
> runtime this period? I get the feeling it's the latter.
>
> So, roughly, it is the ration
>
>        remaining_runtime / relative_time_to_deadline
>
> which needs to be greater than the assigned CPU bandwidth, and if so, the
> budget should be replensihed?
>
> Shouldn't there be something about not refilling the budget before a new
> period has started?
Uh... Maybe the description above can be improved :)
Do you think that using "remaining runtime" instead of "current runtime"
would help? If yes, I'll make this change.

Also, I see that some of your questions are answered by some items below...
Do you think that changing the order of the items in the presentation would
improve the readability? If you suggest a better ordering, I'll try to
rewrite the algorithm's description according to it.


			Thanks,
				Luca
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/