Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753676AbaA0PvH (ORCPT ); Mon, 27 Jan 2014 10:51:07 -0500 Received: from mail-qa0-f50.google.com ([209.85.216.50]:39251 "EHLO mail-qa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753138AbaA0PvF (ORCPT ); Mon, 27 Jan 2014 10:51:05 -0500 Date: Mon, 27 Jan 2014 10:51:02 -0500 (EST) From: Nicolas Pitre To: Catalin Marinas cc: Russell King , Benjamin Herrenschmidt , Paul Mundt , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , "Rafael J. Wysocki" , Daniel Lezcano , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-sh@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linaro-kernel@lists.linaro.org" Subject: Re: [PATCH 2/9] ARM64: get rid of arch_cpu_idle_prepare() In-Reply-To: <20140127154315.GG32608@arm.com> Message-ID: References: <1390802904-28399-1-git-send-email-nicolas.pitre@linaro.org> <1390802904-28399-3-git-send-email-nicolas.pitre@linaro.org> <20140127154315.GG32608@arm.com> User-Agent: Alpine 2.11 (LFD 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Jan 2014, Catalin Marinas wrote: > On Mon, Jan 27, 2014 at 06:08:17AM +0000, Nicolas Pitre wrote: > > ARM and ARM64 are the only two architectures implementing > > arch_cpu_idle_prepare() simply to call local_fiq_enable(). > > > > We have secondary_start_kernel() already calling local_fiq_enable() and > > this is done a second time in arch_cpu_idle_prepare() in that case. And > > enabling FIQs has nothing to do with idling the CPU to start with. > > > > So let's introduce init_fiq_boot_cpu() to take care of FIQs on the boot > > CPU and remove arch_cpu_idle_prepare(). This is now done a bit earlier > > at late_initcall time but this shouldn't make a difference in practice > > given that FIQs are not currently used on ARM64. > > > > Signed-off-by: Nicolas Pitre > > For arm64, we could simply remove any reference to FIQs. I'm not aware > of anyone using them. OK. What if I sumply remove arch_cpu_idle_prepare() and let you do the remove the rest? IMHO I'd simply remove local_fiq_{enable/disable}() from arm64/kernel/smp.c and leave the infrastructure in place in case someone needs it eventually. In which case I could include that into my patch as well. Nicolas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/