Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753960AbaA0PxD (ORCPT ); Mon, 27 Jan 2014 10:53:03 -0500 Received: from mail-ob0-f178.google.com ([209.85.214.178]:47298 "EHLO mail-ob0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753929AbaA0Pw7 (ORCPT ); Mon, 27 Jan 2014 10:52:59 -0500 MIME-Version: 1.0 In-Reply-To: References: <1390795167-6677-1-git-send-email-jcmvbkbc@gmail.com> <1390795167-6677-4-git-send-email-jcmvbkbc@gmail.com> Date: Mon, 27 Jan 2014 19:52:58 +0400 Message-ID: Subject: Re: [PATCH 3/3] net: ethoc: document OF bindings From: Max Filippov To: Rob Herring Cc: "linux-xtensa@linux-xtensa.org" , netdev , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Chris Zankel , Marc Gauthier , "David S. Miller" , Grant Likely , Rob Herring Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On Mon, Jan 27, 2014 at 6:10 PM, Rob Herring wrote: > On Sun, Jan 26, 2014 at 9:59 PM, Max Filippov wrote: >> Signed-off-by: Max Filippov >> --- >> .../devicetree/bindings/net/opencores-ethoc.txt | 25 ++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/opencores-ethoc.txt >> >> diff --git a/Documentation/devicetree/bindings/net/opencores-ethoc.txt b/Documentation/devicetree/bindings/net/opencores-ethoc.txt >> new file mode 100644 >> index 0000000..f7c6c94 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/opencores-ethoc.txt >> @@ -0,0 +1,25 @@ >> +* OpenCores MAC 10/100 Mbps >> + >> +Required properties: >> +- compatible: Should be "opencores,ethoc". > > There are not different versions of IP or is the version probeable? AFAIK there's single version of this 10/100 MAC. It doesn't have any identification registers. >> +- reg: Address and length of the register set for the device and of its >> + descriptor memory. >> +- interrupts: Should contain ethoc interrupt. >> + >> +Optional properties: >> +- local-mac-address: 6 bytes, mac address > > There's a patch in progress to move all the standard network > properties to a common location, so you can remove this. Will do. >> +- clock-frequency: basic MAC frequency. >> +- mii-mgmt-clock-frequency: frequency of MII management bus. Together >> + with clock-frequency determines the value programmed into the CLKDIV >> + field of MIIMODER register. >> + >> +Examples: >> + >> + enet0: ethoc@fd030000 { >> + compatible = "opencores,ethoc"; >> + reg = <0xfd030000 0x4000 0xfd800000 0x4000>; >> + interrupts = <1>; >> + local-mac-address = [00 50 c2 13 6f 00]; >> + clock-frequency = <50000000>; >> + mii-mgmt-clock-frequency = <5000000>; >> + }; >> -- >> 1.8.1.4 -- Thanks. -- Max -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/