Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753991AbaA0P4P (ORCPT ); Mon, 27 Jan 2014 10:56:15 -0500 Received: from mail-vc0-f178.google.com ([209.85.220.178]:61645 "EHLO mail-vc0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753516AbaA0P4O (ORCPT ); Mon, 27 Jan 2014 10:56:14 -0500 MIME-Version: 1.0 In-Reply-To: <1390823503-24087-4-git-send-email-alchark@gmail.com> References: <1385227995-3956-1-git-send-email-alchark@gmail.com> <1390823503-24087-1-git-send-email-alchark@gmail.com> <1390823503-24087-4-git-send-email-alchark@gmail.com> Date: Mon, 27 Jan 2014 09:56:12 -0600 Message-ID: Subject: Re: [PATCH 3/3] net: via-rhine: add OF bus binding From: Rob Herring To: Alexey Charkov Cc: netdev , Tony Prisk , "devicetree@vger.kernel.org" , rl@hellgate.ch, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 27, 2014 at 5:51 AM, Alexey Charkov wrote: > This should make the driver usable with VIA/WonderMedia ARM-based > Systems-on-Chip integrated Rhine III adapters. Note that these > are always in MMIO mode, and don't have any known EEPROM. > > Signed-off-by: Alexey Charkov > Signed-off-by: Roger Luethi > --- > .../devicetree/bindings/net/via-rhine.txt | 18 ++ > drivers/net/ethernet/via/Kconfig | 2 +- > drivers/net/ethernet/via/via-rhine.c | 293 +++++++++++++-------- > 3 files changed, 200 insertions(+), 113 deletions(-) > create mode 100644 Documentation/devicetree/bindings/net/via-rhine.txt > > diff --git a/Documentation/devicetree/bindings/net/via-rhine.txt b/Documentation/devicetree/bindings/net/via-rhine.txt > new file mode 100644 > index 0000000..684dd3a > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/via-rhine.txt > @@ -0,0 +1,18 @@ > +* VIA Rhine 10/100 Network Controller > + > +Required properties: > +- compatible : Should be "via,rhine" This should be more specific rather than... > +- reg : Address and length of the io space > +- interrupts : Should contain the controller interrupt line > +- rhine,revision : Rhine core revision, used to inform the > + driver of quirks and capabilities to expect from > + the device. Mimics the respective PCI attribute. having this property. The OF match table can then have the quirks set based on compatible strings. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/