Message-ID: <1390849530.1792.513.camel@misato.fc.hp.com>
Subject: Re: [PATCH v2] x86, mm: Avoid duplicated pxm_to_node() calling.
From: Toshi Kani <toshi.kani@hp.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Rientjes <rientjes@google.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Date: Mon, 27 Jan 2014 12:05:30 -0700
In-Reply-To: <CAE9FiQUZ8WD3nNAr=Y946y7=hqMfkqa72N-5fpOrGfaE4KTYfA@mail.gmail.com>
References: <1390770102-4007-1-git-send-email-yinghai@kernel.org>
	 <1390834182.1792.512.camel@misato.fc.hp.com>
	 <CAE9FiQUZ8WD3nNAr=Y946y7=hqMfkqa72N-5fpOrGfaE4KTYfA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Mon, 2014-01-27 at 11:08 -0800, Yinghai Lu wrote:
> On Mon, Jan 27, 2014 at 6:49 AM, Toshi Kani <toshi.kani@hp.com> wrote:
> > On Sun, 2014-01-26 at 13:01 -0800, Yinghai Lu wrote:
> >> In slit init code, more pxm_to_node() calling are added.
> >>
> >> We can store from_node/to_node instead of keep calling pxm_to_node().
> >>
> >> After this patch: pxm_to_node() is called n*(1+n)
> >> Before this patch: pxm_to_node() is called n*(1+n*3)
> >>
> >> for 8 socket, it will be 72 instead of 200.
> >> for 32 socket, it will be 1056 instead of 3104.
> >>
> >> -v2: update title and change log according to Ingo.
> >>      move from_node/to_node in loop and change to const according to
> >>       David Rientjes.
> >>
> >> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> >
> > In my original patch, I added the following comment to the function to
> > address David's comment (which he acked).  So, can you add this comment?
> >
> > -/* Callback for SLIT parsing */
> > +/*
> > + * Callback for SLIT parsing.  pxm_to_node() returns NUMA_NO_NODE for
> > + * I/O localities since SRAT does not list them.  I/O localities are
> > + * not supported at this point.
> > + */
> >
> > Otherwise, the change looks good to me.
> >
> > Acked-by: Toshi Kani <toshi.kani@hp.com>
> 
> Hi, Toshi,
> 
> This patch is delta patch to your patch that is in tip already.
> 
> So you comments change is still there and not touched.

Hi Yinghai,

Sounds great!  Thanks for the clarification!

-Toshi


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/