Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751013AbaA1FOz (ORCPT ); Tue, 28 Jan 2014 00:14:55 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:58164 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750747AbaA1FOx (ORCPT ); Tue, 28 Jan 2014 00:14:53 -0500 X-IronPort-AV: E=Sophos;i="4.95,733,1384272000"; d="scan'208";a="9460455" Message-ID: <52E73D61.8000304@cn.fujitsu.com> Date: Tue, 28 Jan 2014 13:17:21 +0800 From: Tang Chen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Dave Jones , David Rientjes , tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, akpm@linux-foundation.org, zhangyanfei@cn.fujitsu.com, guz.fnst@cn.fujitsu.com, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] numa, mem-hotplug: Fix stack overflow in numa when seting kernel nodes to unhotpluggable. References: <1390456168-28259-1-git-send-email-tangchen@cn.fujitsu.com> <52E70165.8070709@cn.fujitsu.com> <20140128025537.GA21730@redhat.com> <52E722F5.9010505@cn.fujitsu.com> <20140128035518.GA25386@redhat.com> <52E7364F.5010700@cn.fujitsu.com> <20140128044749.GA27164@redhat.com> In-Reply-To: <20140128044749.GA27164@redhat.com> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2014/01/28 13:13:15, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2014/01/28 13:13:18, Serialize complete at 2014/01/28 13:13:18 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/28/2014 12:47 PM, Dave Jones wrote: > On Tue, Jan 28, 2014 at 12:47:11PM +0800, Tang Chen wrote: > > On 01/28/2014 11:55 AM, Dave Jones wrote: > > > On Tue, Jan 28, 2014 at 11:24:37AM +0800, Tang Chen wrote: > > > > > > > > I did a bisect with the patch above applied each step of the way. > > > > > This time I got a plausible looking result.... > > > > > > > > I cannot reproduce this. Would you please share how to reproduce it ? > > > > Or does it just happen during the booting ? > > > > > > Just during boot. Very early. So early in fact, I have no logging facilities > > > like usb-serial, just what is on vga console. > > > > > > If you want me to add some printk's, I can add a while (1); before > > > the part that oopses so we can diagnose further.. > > > > Sure. Would you please do that for me ? Maybe we can find something in > > the early log. > > I was hoping you'd have suggestions what you'd like me to dump ;-) Sorry. I didn't say it clearly. :) Seeing from your earlier mail, it crashed at: while (zonelist_zone_idx(z) > highest_zoneidx) de: 3b 77 08 cmp 0x8(%rdi),%esi I stuck this at the top of the function.. printk(KERN_ERR "z:%p nodes:%p highest:%d\n", z, nodes, highest_zoneidx); and got z: 1d08 nodes: (null) highest:3 nodes=null and highest=3, they are correct. When looking into next_zones_zonelist(), I cannot see why it crashed. So, can you print the zone id in the for_each_zone_zonelist() loop in nr_free_zone_pages() ? I want to know why it crashed. A NULL pointer ? Which one ? Thanks. > > Dave > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/