Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755053AbaA1LM3 (ORCPT ); Tue, 28 Jan 2014 06:12:29 -0500 Received: from cantor2.suse.de ([195.135.220.15]:55866 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753485AbaA1LM2 (ORCPT ); Tue, 28 Jan 2014 06:12:28 -0500 Date: Tue, 28 Jan 2014 12:12:26 +0100 Message-ID: From: Takashi Iwai To: Mark Brown Cc: Russell King - ARM Linux , Jean-Francois Moine , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Clark , Dave Airlie , linux-arm-kernel@lists.infradead.org Subject: Re: [alsa-devel] [PATCH 4/4] ASoC: tda998x: adjust the audio hw parameters from EDID In-Reply-To: <20140128110051.GI11841@sirena.org.uk> References: <20140127204441.GZ11841@sirena.org.uk> <20140127204915.GC15937@n2100.arm.linux.org.uk> <20140127205437.GC11841@sirena.org.uk> <20140128110051.GI11841@sirena.org.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 28 Jan 2014 11:00:51 +0000, Mark Brown wrote: > > On Tue, Jan 28, 2014 at 10:23:57AM +0100, Takashi Iwai wrote: > > Mark Brown wrote: > > > On Mon, Jan 27, 2014 at 08:49:15PM +0000, Russell King - ARM Linux wrote: > > > > > Yes, preferably as a generic ALSA helper rather than an ASoC helper - > > > > I don't see any need for this to be ASoC specific (I have a pure ALSA > > > > driver which has very similar code in it.) > > > > Indeed, definitely ALSA generic - ideally we could factor a lot of the > > > integration with the video side out. > > > Yes, indeed. > > > OTOH, as discussed recently, we're heading to move from ELD parsing to > > more direct communication between video and audio drivers for > > HD-audio. ELD will be still provided to user-space, but not evaluated > > any longer in the new scenario. > > That sort of refactoring being one of the best reasons to keep things > out of individual drivers! Having said all this I don't know if it's > worth blocking Jean-Francois' work on that, it's an improvement in > itself. Splitting the code out a bit would be good to help prepare but > having the full refactoring done might be too much of a blocker. I just rather wanted to point out the general direction for the further development, didn't mean NAK. Jean-Francois' patch itself looks simple enough, so I see no problem to take it for now as is. Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/