Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755553AbaA1SbX (ORCPT ); Tue, 28 Jan 2014 13:31:23 -0500 Received: from mail-ee0-f52.google.com ([74.125.83.52]:44340 "EHLO mail-ee0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753894AbaA1SbV (ORCPT ); Tue, 28 Jan 2014 13:31:21 -0500 MIME-Version: 1.0 In-Reply-To: <1390866011.4405.2.camel@deadeye.wl.decadent.org.uk> References: <1385227995-3956-1-git-send-email-alchark@gmail.com> <1390823503-24087-1-git-send-email-alchark@gmail.com> <1390823503-24087-4-git-send-email-alchark@gmail.com> <1390834654.2735.148.camel@deadeye.wl.decadent.org.uk> <1390866011.4405.2.camel@deadeye.wl.decadent.org.uk> Date: Tue, 28 Jan 2014 22:31:20 +0400 Message-ID: Subject: Re: [PATCH 3/3] net: via-rhine: add OF bus binding From: Alexey Charkov To: Ben Hutchings Cc: netdev , Tony Prisk , "devicetree@vger.kernel.org" , Roger Luethi , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2014/1/28 Ben Hutchings : > On Mon, 2014-01-27 at 19:34 +0400, Alexey Charkov wrote: >> 2014/1/27 Ben Hutchings : >> > On Mon, 2014-01-27 at 15:51 +0400, Alexey Charkov wrote: >> >> This should make the driver usable with VIA/WonderMedia ARM-based >> >> Systems-on-Chip integrated Rhine III adapters. Note that these >> >> are always in MMIO mode, and don't have any known EEPROM. >> > [...] >> >> --- a/drivers/net/ethernet/via/Kconfig >> >> +++ b/drivers/net/ethernet/via/Kconfig >> >> @@ -19,7 +19,7 @@ if NET_VENDOR_VIA >> >> >> >> config VIA_RHINE >> >> tristate "VIA Rhine support" >> >> - depends on PCI >> >> + depends on (PCI || USE_OF) >> >> select CRC32 >> >> select MII >> >> ---help--- >> > >> > This seems like the right thing to do, but it means you need to add >> > #ifdef CONFIG_PCI and #ifdef CONFIG_USE_OF around the driver structures >> > and related functions. >> >> Frankly, I would like to avoid that if possible (as pointed out in the >> cover email), as I believe we would get a cleaner driver without >> #ifdef. This is also the way it was done in via-velocity, and it works >> just fine. > > OK, I'm surprised that all the PCI functions have dummy definitions. > >> > You should compile-test in configurations that have just one of those >> > dependencies enabled. >> >> This has been compile-tested and runtime-tested in OF-only >> configuration on WM8950, and Roger also tested it in PCI-only >> configuration, so it seems to work fine. > [...] > > Good, then I have no objection. Thanks Ben! Would it be fine to add your Reviewed-by at the next iteration, once I fix indentation of function arguments and dev_is_pci()? Thanks, Alexey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/