Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932263AbaA1UUp (ORCPT ); Tue, 28 Jan 2014 15:20:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:13239 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932117AbaA1UUn (ORCPT ); Tue, 28 Jan 2014 15:20:43 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20140126122729.32113.19659.stgit@warthog.procyon.org.uk> To: Linus Torvalds Cc: dhowells@redhat.com, Linux Kernel Mailing List , linux-afs@lists.infradead.org, =?UTF-8?Q?Pali_Roh=C3=A1r?= Subject: Re: [PATCH] afs: proc cells and rootcell are writeable Date: Tue, 28 Jan 2014 20:20:12 +0000 Message-ID: <10828.1390940412@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linus Torvalds wrote: > > - p = proc_create("cells", 0, proc_afs, &afs_proc_cells_fops); > > + p = proc_create("cells", S_IFREG | S_IRUGO | S_IWUSR, proc_afs, &afs_proc_cells_fops); > > - p = proc_create("rootcell", 0, proc_afs, &afs_proc_rootcell_fops); > > + p = proc_create("rootcell", S_IFREG | S_IRUGO | S_IWUSR, proc_afs, &afs_proc_rootcell_fops); > > So the S_IFREG isn't necessary. True. Is it worth creating proc_create_special() that can create a non-regular file and then making proc_create() only permit regular files (and complain if the S_IFMT field is not zero)? > And quite frankly, I personally think S_IRUGO | S_IWUSR is _less_ > readable than 0644. It's damn hard to parse those random letter > combinations, and at least I have to really think about it, in a way > that the octal representation does *not* make me go "I have to think > about that". Fine by me. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/