Message-ID: <1390943840.11839.10.camel@buesod1.americas.hpqcorp.net>
Subject: Re: [PATCH v2 2/5] mutex: Modify the way optimistic spinners are
 queued
From: Davidlohr Bueso <davidlohr@hp.com>
To: paulmck@linux.vnet.ibm.com
Cc: Jason Low <jason.low2@hp.com>, mingo@redhat.com, peterz@infradead.org,
        Waiman.Long@hp.com, torvalds@linux-foundation.org, tglx@linutronix.de,
        linux-kernel@vger.kernel.org, riel@redhat.com,
        akpm@linux-foundation.org, hpa@zytor.com, andi@firstfloor.org,
        aswin@hp.com, scott.norton@hp.com, chegu_vinod@hp.com
Date: Tue, 28 Jan 2014 13:17:20 -0800
In-Reply-To: <20140128202334.GO9012@linux.vnet.ibm.com>
References: <1390936396-3962-1-git-send-email-jason.low2@hp.com>
	 <1390936396-3962-3-git-send-email-jason.low2@hp.com>
	 <20140128202334.GO9012@linux.vnet.ibm.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Tue, 2014-01-28 at 12:23 -0800, Paul E. McKenney wrote:
> On Tue, Jan 28, 2014 at 11:13:13AM -0800, Jason Low wrote:
> > ...
> >  		if (!owner && (need_resched() || rt_task(task)))
> > -			goto slowpath;
> > +			break;
> > 
> >  		/*
> >  		 * The cpu_relax() call is a compiler barrier which forces
> > @@ -514,6 +511,7 @@ __mutex_lock_common(struct mutex *lock, long state, unsigned int subclass,
> >  		 */
> >  		arch_mutex_cpu_relax();
> >  	}
> > +	mspin_unlock(MLOCK(lock), &node);
> >  slowpath:
> 
> Are there any remaining goto statements to slowpath?  If so, they need
> to release the lock.  If not, this label should be removed.

We still have the !mutex_can_spin_on_owner case.

Thanks,
Davidlohr

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/