Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756004AbaA1Xdl (ORCPT ); Tue, 28 Jan 2014 18:33:41 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:36212 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1755294AbaA1Xdh (ORCPT ); Tue, 28 Jan 2014 18:33:37 -0500 X-IronPort-AV: E=Sophos;i="4.95,739,1384272000"; d="scan'208";a="9462648" Message-ID: <52E83EE8.1030404@cn.fujitsu.com> Date: Wed, 29 Jan 2014 07:36:08 +0800 From: Tang Chen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Ingo Molnar CC: David Rientjes , davej@redhat.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, Andrew Morton , zhangyanfei@cn.fujitsu.com, guz.fnst@cn.fujitsu.com, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] numa, mem-hotplug: Initialize numa_kernel_nodes in numa_clear_kernel_node_hotplug(). References: <1390899916-23566-1-git-send-email-tangchen@cn.fujitsu.com> <1390899916-23566-2-git-send-email-tangchen@cn.fujitsu.com> <20140128114826.GA26103@gmail.com> In-Reply-To: <20140128114826.GA26103@gmail.com> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2014/01/29 07:31:59, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2014/01/29 07:32:00, Serialize complete at 2014/01/29 07:32:00 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/28/2014 07:48 PM, Ingo Molnar wrote: > > * David Rientjes wrote: > >> On Tue, 28 Jan 2014, Tang Chen wrote: >> >>> On-stack variable numa_kernel_nodes in numa_clear_kernel_node_hotplug() >>> was not initialized. So we need to initialize it. >>> >>> Signed-off-by: Tang Chen >>> Tested-by: Gu Zheng >> >> Reported-by: David Rientjes > > Agreed. Tang Chen, please also spell it out in the changelog: > > David Rientjes reported a boot crash, caused by > commit XYZ ("foo: bar"). > > I find it somewhat annoying that you found time to credit a corporate > collegue with a Tested-by tag, who didn't even reply to the whole > thread to indicate his testing efforts, but you didn't find the time > to credit the original reporter of the bug who also reviewed your > patches ... Hi David, Ingo, I'm sorry for the missing original reporter. I was paying so much attention to the second patch. And Andrew has added the missing info and committed the patch. :) Thanks. > > Thanks, > > Ingo > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/