Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S265019AbSKANjB>; Fri, 1 Nov 2002 08:39:01 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S265026AbSKANjB>; Fri, 1 Nov 2002 08:39:01 -0500
Received: from ns.suse.de ([213.95.15.193]:32274 "EHLO Cantor.suse.de")
	by vger.kernel.org with ESMTP id <S265019AbSKANh5>;
	Fri, 1 Nov 2002 08:37:57 -0500
Date: Fri, 01 Nov 2002 14:44:25 +0100
Message-ID: <s5h7kfxs8ue.wl@alsa2.suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Osamu Tomita <tomita@cinet.co.jp>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHSET 22/25] add support for PC-9800 architecture (sound alsa)
In-Reply-To: <20021101220218.A12315@precia.cinet.co.jp>
References: <20021026115417.A1424@precia.cinet.co.jp>
	<s5hu1j630qh.wl@alsa2.suse.de>
	<s5hsmyp36c4.wl@alsa2.suse.de>
	<3DBEC8BA.F2043BEF@cinet.co.jp>
	<s5hhef3byq1.wl@alsa2.suse.de>
	<20021101220218.A12315@precia.cinet.co.jp>
User-Agent: Wanderlust/2.6.1 (Upside Down) SEMI/1.14.4 (Hosorogi)
 FLIM/1.14.4 (=?ISO-8859-4?Q?Kashiharajing=FE-mae?=) APEL/10.2 MULE
 XEmacs/21.4 (patch 8) (Honest Recruiter) (i386-suse-linux)
MIME-Version: 1.0 (generated by SEMI 1.14.4 - "Hosorogi")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1882
Lines: 56

At Fri, 1 Nov 2002 22:02:18 +0900,
Osamu Tomita wrote:
> 
> 2002.10.31 02:52, Takashi Iwai wrote:
> > At Wed, 30 Oct 2002 02:43:22 +0900,
> (snip)
> > do you mean that the interrupts are generated too slowly?
> > you can measure how many UART interrupts are generated per second by
> > checking /proc/interrupts.
> > if it's too little, the problem is likely in the hardware
> > initialization part, which i simply copied from your patch.
> > but it could be a wrong copy & paste.
> > please check pc98_mpu401_init() in pc98.c.
> > 
> > btw, which MPU mode are you using, PC98II or normal MPU401?
> Thanks! Problem solved. MPU401 works fine by trivial fix as follows.
> 
> #--- linux/sound/isa/cs423x/pc98.c.old	Wed Oct 30 00:20:35 2002
> #+++ linux/sound/isa/cs423x/pc98.c	Fri Nov  1 20:45:31 2002
> #@@ -379,7 +379,7 @@
> # 		err = pc98_mpu401_init(mpu_irq[dev]);
> # 		if (! err) {
> # 			err = snd_mpu401_uart_new(card, 0,
> #-						  pc98ii ? 
> MPU401_HW_PC98II : MPU401_HW_MPU401,
> #+						  pc98ii[dev] ? 
> MPU401_HW_PC98II : MPU401_HW_MPU401,
> # 						  mpu_port[dev], 0,
> # 						  mpu_irq[dev], 
> SA_INTERRUPT, NULL);
> # 			if (err < 0)

d'oh.  thanks.

> 
> Now, PCM OPL3 and MPU401 all works fine.
> Would you please add option "pc98ii" into snd-mpu401?
> This is for Box that has MPU-PC98II only, with no other sound card.

well, then i misunderstood the hardware configuration on PC98.

doesn't MPU-PC98II need any specific hardware init code like in
pc98_mpu401_init()?

if yes, then we should create another module for PC98II rather than
including a magical init code into a generic mpu401 module.


ciao,

Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/