Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755977AbaA2DoI (ORCPT ); Tue, 28 Jan 2014 22:44:08 -0500 Received: from server.prisktech.co.nz ([115.188.14.127]:58932 "EHLO server.prisktech.co.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755236AbaA2DoG (ORCPT ); Tue, 28 Jan 2014 22:44:06 -0500 Message-ID: <52E87929.30708@prisktech.co.nz> Date: Wed, 29 Jan 2014 16:44:41 +1300 From: Tony Prisk User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Alexey Charkov , Rob Herring CC: netdev , "devicetree@vger.kernel.org" , Roger Luethi , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 3/3] net: via-rhine: add OF bus binding References: <1385227995-3956-1-git-send-email-alchark@gmail.com> <1390823503-24087-1-git-send-email-alchark@gmail.com> <1390823503-24087-4-git-send-email-alchark@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/01/14 07:27, Alexey Charkov wrote: > 2014/1/27 Rob Herring : >> On Mon, Jan 27, 2014 at 5:51 AM, Alexey Charkov wrote: >>> This should make the driver usable with VIA/WonderMedia ARM-based >>> Systems-on-Chip integrated Rhine III adapters. Note that these >>> are always in MMIO mode, and don't have any known EEPROM. >>> >>> Signed-off-by: Alexey Charkov >>> Signed-off-by: Roger Luethi >>> --- >>> .../devicetree/bindings/net/via-rhine.txt | 18 ++ >>> drivers/net/ethernet/via/Kconfig | 2 +- >>> drivers/net/ethernet/via/via-rhine.c | 293 +++++++++++++-------- >>> 3 files changed, 200 insertions(+), 113 deletions(-) >>> create mode 100644 Documentation/devicetree/bindings/net/via-rhine.txt >>> >>> diff --git a/Documentation/devicetree/bindings/net/via-rhine.txt b/Documentation/devicetree/bindings/net/via-rhine.txt >>> new file mode 100644 >>> index 0000000..684dd3a >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/net/via-rhine.txt >>> @@ -0,0 +1,18 @@ >>> +* VIA Rhine 10/100 Network Controller >>> + >>> +Required properties: >>> +- compatible : Should be "via,rhine" >> This should be more specific rather than... >> >>> +- reg : Address and length of the io space >>> +- interrupts : Should contain the controller interrupt line >>> +- rhine,revision : Rhine core revision, used to inform the >>> + driver of quirks and capabilities to expect from >>> + the device. Mimics the respective PCI attribute. >> having this property. The OF match table can then have the quirks set >> based on compatible strings. > Sounds fair. Do you think something like the following would fly? > > Required properties: > - compatible : Should be "via,rhine-soc-vt8500" for integrated Rhine > cores found in SoC's such as VIA VT8500, WonderMedia WM8950 and > possibly others. These are listed as 1106:3106 rev. 0x84 on the > virtual PCI bus under vendor-provided kernels. Does it need a special name? I would have assumed they are using their own IP for the VT6105 or VT6106S. Then you can use it to add quirks later on if needed. Regards Tony Prisk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/