Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752164AbaA2GIY (ORCPT ); Wed, 29 Jan 2014 01:08:24 -0500 Received: from cobra.newdream.net ([66.33.216.30]:52624 "EHLO cobra.newdream.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750904AbaA2GIW (ORCPT ); Wed, 29 Jan 2014 01:08:22 -0500 Date: Tue, 28 Jan 2014 22:08:22 -0800 (PST) From: Sage Weil X-X-Sender: sage@cobra.newdream.net To: Linus Torvalds cc: Dave Jones , Linux Kernel Mailing List , ceph-devel@vger.kernel.org, linux-fsdevel , Christoph Hellwig , Al Viro , Guangliang Zhao , Li Wang , zheng.z.yan@intel.com Subject: Re: [GIT PULL] Ceph updates for -rc1 In-Reply-To: Message-ID: References: <20140128211021.GB1377@redhat.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, On Tue, 28 Jan 2014, Linus Torvalds wrote: > On Tue, Jan 28, 2014 at 1:10 PM, Dave Jones wrote: > > > > This breaks the build for me. > > It is my merge (Christoph's ACL changes came in today through the VFS > tree from Al). > > I was doing the merges today on my laptop (I had jury duty yesterday > and today), and so I didn't do the allmodconfig build I would normally > do on my (much faster) desktop. Well, actually I did do the full fs > builds for the earlier pulls that actually had some conflicts, but not > for the ceph pull. The conflict was hidden by the fact that the whole > cifs ACL support is new, so there was no data conflict, just a silent > semantic conflict between the new smarter ACL helpers and the new ACL > use in CIFS. s/cifs/ceph/ :) > I'm back home now (yay, all the afternoon cases got settled), and I > see the problem now. I should have done an allmodconfig build > immediately after coming home, but I never even thought of it. > > Anyway, here's an *untested* conversion to the new posix acl helper > infrastructure. I do wonder if ceph_init_acl() could be converted to > posix_acl_create(), right now that part is a "non-conversion" - it's > just made to use __posix_acl_create() that implements the old > interface. > > Al, Christoph, can you please check my conversion for sanity from a > generic posix-acl standpoint? > > Sage, Guangliang, Li, can you check the actual cifs usage/sanity of > the attached patch? Superficially at least the conversion looks okay to me, but it's not passing my smoke test (it's giving me EOPNOTSUPP for chmod and setxattr when setting an ACL). I'll look at it tomorrow if Guangliang, Li, or Yan don't get there first. I should have caught this before--I knew the ACL changes were coming and forgot to check the merged build beforehand! sage -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/