Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752761AbaA2SBt (ORCPT ); Wed, 29 Jan 2014 13:01:49 -0500 Received: from mail-wg0-f48.google.com ([74.125.82.48]:60188 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751116AbaA2SBr (ORCPT ); Wed, 29 Jan 2014 13:01:47 -0500 Message-ID: <52E94204.1050207@gmail.com> Date: Wed, 29 Jan 2014 19:01:40 +0100 From: Boris BREZILLON User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Rob Herring CC: Maxime Ripard , Rob Landley , Russell King , David Woodhouse , Grant Likely , Brian Norris , Jason Gunthorpe , Arnd Bergmann , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-mtd@lists.infradead.org, dev@linux-sunxi.org Subject: Re: [RFC PATCH v2 09/14] mtd: nand: add sunxi NFC dt bindings doc References: <1391006064-28890-1-git-send-email-b.brezillon.dev@gmail.com> <1391006064-28890-10-git-send-email-b.brezillon.dev@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Rob, Le 29/01/2014 18:11, Rob Herring a ?crit : > On Wed, Jan 29, 2014 at 8:34 AM, Boris BREZILLON > wrote: >> Add the sunxi NAND Flash Controller dt bindings documentation. >> >> Signed-off-by: Boris BREZILLON >> --- >> .../devicetree/bindings/mtd/sunxi-nand.txt | 46 ++++++++++++++++++++ >> 1 file changed, 46 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mtd/sunxi-nand.txt >> >> diff --git a/Documentation/devicetree/bindings/mtd/sunxi-nand.txt b/Documentation/devicetree/bindings/mtd/sunxi-nand.txt >> new file mode 100644 >> index 0000000..b0e55a3 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mtd/sunxi-nand.txt >> @@ -0,0 +1,46 @@ >> +Allwinner NAND Flash Controller (NFC) >> + >> +Required properties: >> +- compatible : "allwinner,sun4i-nand". >> +- reg : shall contain registers location and length for data and reg. >> +- interrupts : shall define the nand controller interrupt. >> +- #address-cells: shall be set to 1. Encode the nand CS. >> +- #size-cells : shall be set to 0. >> +- clocks : shall reference nand controller clocks. >> +- clock-names : nand controller internal clock names. Shall contain : >> + * "ahb_clk" : AHB gating clock >> + * "sclk" : nand controller clock >> + >> +Optional children nodes: >> +Children nodes represent the available nand chips. >> + >> +Optional properties: > For the controller or per nand chip? > >> +- onfi,nand-timing-mode : mandatory if the chip does not support the ONFI >> + standard. > Add to generic nand binding. > >> +- allwinner,rb : shall contain the native Ready/Busy ids. >> + or >> +- rb-gpios : shall contain the gpios used as R/B pins. > Isn't allwinner,rb implied by a lack of rb-gpios property. Or no R/B > pin is an option? Both are optional. In case none of the properties are defined the dev_ready callback is set to NULL and the nand_base waiting loop is used. > If so, don't you need some fixed time delay > properties like max erase time? This is handled in nand_base (using the chip_delay field), but I guess we could use the information retrieved from nand timings and the operation in progress... > rb-gpios could be added to the generic nand binding as well. Sure. > > Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/