Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753563AbaA3VWy (ORCPT ); Thu, 30 Jan 2014 16:22:54 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:42790 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753108AbaA3VWx (ORCPT ); Thu, 30 Jan 2014 16:22:53 -0500 Date: Thu, 30 Jan 2014 13:22:51 -0800 From: Andrew Morton To: Sebastian Capella Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org, linaro-kernel@lists.linaro.org, patches@linaro.org, Joe Perches , Mikulas Patocka , Michel Lespinasse , Shaohua Li , Jerome Marchand , Joonsoo Kim Subject: Re: [PATCH v5 1/2] mm: add kstrimdup function Message-Id: <20140130132251.4f662aeddc09d8410dee4490@linux-foundation.org> In-Reply-To: <1391116318-17253-2-git-send-email-sebastian.capella@linaro.org> References: <1391116318-17253-1-git-send-email-sebastian.capella@linaro.org> <1391116318-17253-2-git-send-email-sebastian.capella@linaro.org> X-Mailer: Sylpheed 3.2.0beta5 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 30 Jan 2014 13:11:57 -0800 Sebastian Capella wrote: > kstrimdup will duplicate and trim spaces from the passed in > null terminated string. This is useful for strings coming from > sysfs that often include trailing whitespace due to user input. > > ... > > --- a/include/linux/string.h > +++ b/include/linux/string.h > > ... > > @@ -63,6 +64,35 @@ char *kstrndup(const char *s, size_t max, gfp_t gfp) > EXPORT_SYMBOL(kstrndup); > > /** > + * kstrimdup - Trim and copy a %NUL terminated string. > + * @s: the string to trim and duplicate > + * @gfp: the GFP mask used in the kmalloc() call when allocating memory > + * > + * Returns an address, which the caller must kfree, containing > + * a duplicate of the passed string with leading and/or trailing > + * whitespace (as defined by isspace) removed. > + */ > +char *kstrimdup(const char *s, gfp_t gfp) > +{ > + char *buf; > + char *begin = skip_spaces(s); > + size_t len = strlen(begin); > + > + while (len > 1 && isspace(begin[len - 1])) > + len--; That's off-by-one isn't it? kstrimdup(" ") should return "", not " ". > + buf = kmalloc_track_caller(len + 1, gfp); > + if (!buf) > + return NULL; > + > + memcpy(buf, begin, len); > + buf[len] = '\0'; > + > + return buf; > +} > +EXPORT_SYMBOL(kstrimdup); > + -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/