Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932200AbaAaKNy (ORCPT ); Fri, 31 Jan 2014 05:13:54 -0500 Received: from mail-ob0-f172.google.com ([209.85.214.172]:39575 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932072AbaAaKNw (ORCPT ); Fri, 31 Jan 2014 05:13:52 -0500 MIME-Version: 1.0 In-Reply-To: <1390869573-27624-10-git-send-email-sebastian.hesselbarth@gmail.com> References: <1390674856-4993-1-git-send-email-sebastian.hesselbarth@gmail.com> <1390869573-27624-1-git-send-email-sebastian.hesselbarth@gmail.com> <1390869573-27624-10-git-send-email-sebastian.hesselbarth@gmail.com> Date: Fri, 31 Jan 2014 11:13:51 +0100 Message-ID: Subject: Re: [PATCH v2 09/21] pinctrl: mvebu: dove: provide generic mpp callbacks From: Linus Walleij To: Sebastian Hesselbarth Cc: Jason Cooper , Andrew Lunn , Gregory Clement , Thomas Petazzoni , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 28, 2014 at 1:39 AM, Sebastian Hesselbarth wrote: > We want to get rid of passing register addresses to common pinctrl > driver, so provide set/get callbacks for generic mpp pins. > > Signed-off-by: Sebastian Hesselbarth OK... > +static int dove_mpp_ctrl_get(struct mvebu_mpp_ctrl *ctrl, > + unsigned long *config) > +{ (...) This is fine. > @@ -374,7 +398,7 @@ static struct mvebu_mpp_ctrl dove_mpp_controls[] = { > MPP_FUNC_CTRL(13, 13, "mpp13", dove_pmu_mpp_ctrl), > MPP_FUNC_CTRL(14, 14, "mpp14", dove_pmu_mpp_ctrl), > MPP_FUNC_CTRL(15, 15, "mpp15", dove_pmu_mpp_ctrl), > - MPP_REG_CTRL(16, 23), > + MPP_FUNC_CTRL(16, 23, NULL, dove_mpp_ctrl), What does this have to do with the rest of the patch? (Maybe I'm stupid, beware I'm just glancing over this stuff as I see the patch set is still in development.) Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/