Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932905AbaAaPO5 (ORCPT ); Fri, 31 Jan 2014 10:14:57 -0500 Received: from qmta06.emeryville.ca.mail.comcast.net ([76.96.30.56]:51884 "EHLO qmta06.emeryville.ca.mail.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932344AbaAaPOz (ORCPT ); Fri, 31 Jan 2014 10:14:55 -0500 Date: Fri, 31 Jan 2014 09:14:51 -0600 (CST) From: Christoph Lameter X-X-Sender: cl@nuc To: Nishanth Aravamudan cc: David Rientjes , Eric Dumazet , Eric Dumazet , LKML , Anton Blanchard , Andrew Morton , Tejun Heo , Oleg Nesterov , Jan Kara , Thomas Gleixner , Tetsuo Handa , linux-mm@kvack.org, Wanpeng Li , Joonsoo Kim , Ben Herrenschmidt Subject: Re: [PATCH] kthread: ensure locality of task_struct allocations In-Reply-To: <20140130230812.GA874@linux.vnet.ibm.com> Message-ID: References: <20140128183808.GB9315@linux.vnet.ibm.com> <1391062491.28432.68.camel@edumazet-glaptop2.roam.corp.google.com> <20140130230812.GA874@linux.vnet.ibm.com> Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 30 Jan 2014, Nishanth Aravamudan wrote: > In the presence of memoryless nodes, numa_node_id() will return the > current CPU's NUMA node, but that may not be where we expect to allocate > from memory from. Instead, we should rely on the fallback code in the > memory allocator itself, by using NUMA_NO_NODE. Also, when calling > kthread_create_on_node(), use the nearest node with memory to the cpu in > question, rather than the node it is running on. Looks good to me. Reviewed-by: Christoph Lameter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/