Date: Fri, 31 Jan 2014 18:12:54 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: "Pearson, Greg" <greg.pearson@hp.com>
Cc: "vgoyal@redhat.com" <vgoyal@redhat.com>,
        "d.hatayama@jp.fujitsu.com" <d.hatayama@jp.fujitsu.com>,
        "holzheu@linux.vnet.ibm.com" <holzheu@linux.vnet.ibm.com>,
        "dhowells@redhat.com" <dhowells@redhat.com>,
        "paul.gortmaker@windriver.com" <paul.gortmaker@windriver.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] vmcore: prevent PT_NOTE p_memsz overflow during header
 update
Message-Id: <20140131181254.da3f8e97.akpm@linux-foundation.org>
In-Reply-To: <52EC48D0.4000503@hp.com>
References: <1391209566-4734-1-git-send-email-greg.pearson@hp.com>
	<20140131151651.26ff54cd7bd06fc5feb6fcc6@linux-foundation.org>
	<52EC48D0.4000503@hp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Sat, 1 Feb 2014 01:07:29 +0000 "Pearson, Greg" <greg.pearson@hp.com> wrote:

> As far as I know the only consequence of dropping a PT_NOTE entry is 
> that it would not be available in the crash dump for use in debugging. 
> I'm not sure how important this data might be for triage. I'm guessing 
> that in cases where one of these strange PT_NOTE entries shows up with a 
> size that causes an overflow it probably isn't even a real PT_NOTE entry 
> so dropping it won't matter, but that's a guess at this point since I'm 
> still trying to figure out how the bogus entries were created.

Can we detect the crazy-huge notes, skip them and then proceed with
the following sanely-sized ones?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/