Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751049AbaBCIYa (ORCPT ); Mon, 3 Feb 2014 03:24:30 -0500 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:58089 "EHLO e23smtp06.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750716AbaBCIY3 (ORCPT ); Mon, 3 Feb 2014 03:24:29 -0500 Message-ID: <52EF53B5.6050203@linux.vnet.ibm.com> Date: Mon, 03 Feb 2014 14:00:45 +0530 From: Raghavendra K T Organization: IBM User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Andrew Morton CC: Raghavendra K T , Fengguang Wu , David Cohen , Al Viro , Damien Ramonda , Jan Kara , Linus , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH V5] mm readahead: Fix readahead fail for no local memory and limit readahead pages References: <1390388025-1418-1-git-send-email-raghavendra.kt@linux.vnet.ibm.com> In-Reply-To: <1390388025-1418-1-git-send-email-raghavendra.kt@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14020308-7014-0000-0000-00000445BD27 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/22/2014 04:23 PM, Raghavendra K T wrote: > max_sane_readahead returns zero on the cpu having no local memory > node. Fix that by returning a sanitized number of pages viz., > minimum of (requested pages, 4k) > > Result: > fadvise experiment with FADV_WILLNEED on a x240 machine with 1GB testfile > 32GB* 4G RAM numa machine ( 12 iterations) yielded > > Kernel Avg Stddev > base 7.2963 1.10 % > patched 7.2972 1.18 % > > Reviewed-by: Jan Kara > Signed-off-by: Raghavendra K T > --- Could you please let me know what do you feel about the patch ? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/