Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753275AbaBCQsv (ORCPT ); Mon, 3 Feb 2014 11:48:51 -0500 Received: from mail-ie0-f172.google.com ([209.85.223.172]:41609 "EHLO mail-ie0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751912AbaBCQst (ORCPT ); Mon, 3 Feb 2014 11:48:49 -0500 MIME-Version: 1.0 In-Reply-To: <1391316630-29541-1-git-send-email-benjamin.tissoires@redhat.com> References: <1391316630-29541-1-git-send-email-benjamin.tissoires@redhat.com> Date: Mon, 3 Feb 2014 17:48:49 +0100 Message-ID: Subject: Re: [PATCH 00/11] HID: spring cleaning From: David Herrmann To: Benjamin Tissoires Cc: Benjamin Tissoires , Jiri Kosina , Frank Praznik , "open list:HID CORE LAYER" , linux-kernel Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On Sun, Feb 2, 2014 at 5:50 AM, Benjamin Tissoires wrote: > Hi guys, > > This is an attempt to complete the branch for-3.15/ll-driver-new-callbacks: > - try to implement as much as possible ll_driver callbacks (some are still > missing, but I did not had the time to complete it) > - add inliners hid_hw_* for all the ll_driver callbacks > - remove transport dependant callbacks in struct hid_device > - remove the so called "obsolete" hidinput_input_event handler which was used > in 2/4 transport drivers > > Bonus point: 14 files changed, 213 insertions(+), 272 deletions(-) > Yay! > > I made sure I kept the PS3 controller working and the LEDs (on logitech-dj and > on bluetooth keyboard) working. The rest do not mostly need further testing, > the code path did not changed. But still, a review (and some tests) would be a > good idea :) Thanks a lot! Looks all good except for the uhid and i2c changes. But I have commented on those. Cheers David > Cheers, > Benjamin > > PS: obviously, this goes on top on the branch for-3.15/ll-driver-new-callbacks > > Benjamin Tissoires (11): > HID: uHID: implement .raw_request > HID: i2c-hid: implement ll_driver transport-layer callbacks > HID: add inliners for ll_driver transport-layer callbacks > HID: logitech-dj: remove hidinput_input_event > HID: HIDp: remove hidp_hidinput_event > HID: remove hidinput_input_event handler > HID: HIDp: remove duplicated coded > HID: usbhid: remove duplicated code > HID: remove hid_get_raw_report in struct hid_device > HID: introduce helper to access hid_output_raw_report() > HID: move hid_output_raw_report to hid_ll_driver > > drivers/hid/hid-input.c | 12 ++--- > drivers/hid/hid-lg.c | 6 ++- > drivers/hid/hid-logitech-dj.c | 101 +++++++++++++--------------------- > drivers/hid/hid-magicmouse.c | 2 +- > drivers/hid/hid-sony.c | 19 +++++-- > drivers/hid/hid-thingm.c | 4 +- > drivers/hid/hid-wacom.c | 16 +++--- > drivers/hid/hid-wiimote-core.c | 4 +- > drivers/hid/hidraw.c | 11 ++-- > drivers/hid/i2c-hid/i2c-hid.c | 27 +++++++++- > drivers/hid/uhid.c | 20 ++++++- > drivers/hid/usbhid/hid-core.c | 67 +++++------------------ > include/linux/hid.h | 77 ++++++++++++++++++++++---- > net/bluetooth/hidp/core.c | 119 +++++------------------------------------ > 14 files changed, 213 insertions(+), 272 deletions(-) > > -- > 1.8.3.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/