Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753493AbaBCTcP (ORCPT ); Mon, 3 Feb 2014 14:32:15 -0500 Received: from mail.skyhub.de ([78.46.96.112]:47319 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752324AbaBCTcM (ORCPT ); Mon, 3 Feb 2014 14:32:12 -0500 Date: Mon, 3 Feb 2014 20:32:03 +0100 From: Borislav Petkov To: Aravind Gopalakrishnan Cc: dougthompson@xmission.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] AMD64_EDAC: Fix logic to determine channel for F15 M30h processors Message-ID: <20140203193203.GE4281@pd.tnic> References: <1390338216-3873-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <52EFE9B2.9020104@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <52EFE9B2.9020104@amd.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 03, 2014 at 01:10:42PM -0600, Aravind Gopalakrishnan wrote: > On 1/21/2014 3:03 PM, Aravind Gopalakrishnan wrote: > >The current logic that returns (sys_addr >> 8) & 0x7 when > >num_dcts_intlv = 4 is incorrect. We should really be doing- > >If intlv_addr = 0x4, then interleave on bits [9:8] and if > >intlv_addr = 0x5, interleave on bits [10:9]. > > > >Refer F15 M30h BKDG D18F2x110[7:6] (DRAM Controller Select Low) > >(Link:http://support.amd.com/TechDocs/49125_15h_Models_30h-3Fh_BKDG.pdf) > > > >Tested on F15 M30h with mce_inj module and patch did not cause > >any regressions. > > > >Signed-off-by: Aravind Gopalakrishnan > >--- > > > > Ping.. I haven't forgotten you - it's just that I'm not taking any patches during the merge window. Now that it is over, all is back to normal. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/