MIME-Version: 1.0
In-Reply-To: <87mwi8x27b.fsf@devron.myhome.or.jp>
References: <1387953065-2726-1-git-send-email-linkinjeon@gmail.com>
	<87mwi8x27b.fsf@devron.myhome.or.jp>
Date: Tue, 4 Feb 2014 08:04:50 +0900
Message-ID: <CAKYAXd_EYrfF0iQVw5FJRHkGCeMTUoQdx+BogV+-g9vqXeGZdw@mail.gmail.com>
Subject: Re: [PATCH v3 2/6] fat: add fat_fallocate operation
From: Namjae Jeon <linkinjeon@gmail.com>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, Namjae Jeon <namjae.jeon@samsung.com>,
        Amit Sahrawat <a.sahrawat@samsung.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org

2014-02-03, OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>:
>
> Sorry for long delay.
>
> Namjae Jeon <linkinjeon@gmail.com> writes:
>
>> +	if (mode & FALLOC_FL_KEEP_SIZE) {
>> +		/* First compute the number of clusters to be allocated */
>> +		mm_bytes = offset + len - round_up(MSDOS_I(inode)->mmu_private,
>> +			sbi->cluster_size);
>
Hi OGAWA.
> This should use ->i_disksize?
Right, I will fix it.
>
> [...]
>
>> +		/* Release unwritten fallocated blocks on inode eviction. */
>> +		if (MSDOS_I(inode)->mmu_private < MSDOS_I(inode)->i_disksize) {
>> +			int err;
>> +			fat_truncate_blocks(inode, MSDOS_I(inode)->mmu_private);
>> +			/* Fallocate results in updating the i_start/iogstart
>> +			 * for the zero byte file. So, make it return to
>> +			 * original state during evict and commit it
>> +			 * synchrnously to avoid any corruption on the next
>> +			 * access to the cluster chain for the file.
>> +			 */
>> +			err = fat_sync_inode(inode);
>
> Ah, good catch. We have to update i_size. I was forgetting about this.
> Well, sync inode unconditionally would not be good. Maybe, we better to
> use __fat_write_inode() with inode_needs_sync() or such.
Okay, I will change it.

Thanks.
> --
> OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/