Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753845AbaBDCGZ (ORCPT ); Mon, 3 Feb 2014 21:06:25 -0500 Received: from mail-qa0-f54.google.com ([209.85.216.54]:52098 "EHLO mail-qa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752576AbaBDCGY (ORCPT ); Mon, 3 Feb 2014 21:06:24 -0500 Message-ID: <52F04B18.4020905@linaro.org> Date: Mon, 03 Feb 2014 21:06:16 -0500 From: David Long User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: "Jon Medhurst (Tixy)" CC: linux-arm-kernel@lists.infradead.org, Russell King , Peter Zijlstra , Srikar Dronamraju , Oleg Nesterov , Anil S Keshavamurthy , linux-kernel@vger.kernel.org, Rabin Vincent , Ingo Molnar , Paul Mackerras , Arnaldo Carvalho de Melo , Masami Hiramatsu , davem@davemloft.net, Ananth N Mavinakayanahalli Subject: Re: [PATCH v5 05/16] ARM: use a function table for determining instruction interpreter action References: <1390507559-4697-1-git-send-email-dave.long@linaro.org> <1390507559-4697-6-git-send-email-dave.long@linaro.org> <1391437498.3509.11.camel@linaro1.home> In-Reply-To: <1391437498.3509.11.camel@linaro1.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/03/14 09:24, Jon Medhurst (Tixy) wrote: > On Thu, 2014-01-23 at 15:05 -0500, David Long wrote: >> From: "David A. Long" >> >> Make the instruction interpreter call back to semantic action functions >> through a function pointer array provided by the invoker. The interpreter >> decodes the instructions into groups and uses the group number to index >> into the supplied array. kprobes and uprobes code will each supply their >> own array of functions. >> >> Signed-off-by: David A. Long >> --- > > [...] > >> --- a/arch/arm/kernel/probes.c >> +++ b/arch/arm/kernel/probes.c >> @@ -378,10 +378,11 @@ static const int decode_struct_sizes[NUM_DECODE_TYPES] = { >> */ >> int __kprobes >> kprobe_decode_insn(kprobe_opcode_t insn, struct arch_specific_insn *asi, >> - const union decode_item *table, bool thumb) >> + const union decode_item *table, bool thumb, >> + const union decode_action *actions) >> { >> - const struct decode_header *h = (struct decode_header *)table; >> - const struct decode_header *next; >> + struct decode_header *h = (struct decode_header *)table; >> + struct decode_header *next; > > The decode tables are fixed structures which nothing should want to > modify, so I think the const's above should be kept. I believe that > you've had to resort to changing them because the following typedef > lacks a 'const' on the final argument.... > I've made the change. > [...] >> diff --git a/arch/arm/kernel/probes.h b/arch/arm/kernel/probes.h >> index c610fa9..81b6e61 100644 > [...] >> >> +typedef enum kprobe_insn (probes_custom_decode_t)(kprobe_opcode_t, >> + struct arch_specific_insn *, >> + struct decode_header *); >> + > > Adding 'const' above will also have the knock on effect of requiring > const on all the 'custom decode' functions as well. > I've made those numerous changes as well. -dl -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/