Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754026AbaBDCZo (ORCPT ); Mon, 3 Feb 2014 21:25:44 -0500 Received: from mail-pa0-f50.google.com ([209.85.220.50]:49201 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753218AbaBDCZl (ORCPT ); Mon, 3 Feb 2014 21:25:41 -0500 Message-ID: <52F04FA8.8040008@gmail.com> Date: Tue, 04 Feb 2014 10:25:44 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Masami Hiramatsu CC: ananth@in.ibm.com, anil.s.keshavamurthy@intel.com, hskinnemoen@gmail.com, David Miller , "linux-kernel@vger.kernel.org" , egtvedt@samfundet.no, "yrl.pp-manager.tt@hitachi.com" Subject: Re: [PATCH] kernel/kprobes.c: move cleanup_rp_inst() to where CONFIG_KRETPROBES enabled References: <52ECE5D8.6090209@gmail.com> <52EDB022.5070101@hitachi.com> <52EF8222.6030709@gmail.com> <52EFB8F4.6010207@hitachi.com> In-Reply-To: <52EFB8F4.6010207@hitachi.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/03/2014 11:42 PM, Masami Hiramatsu wrote: > (2014/02/03 20:48), Chen Gang wrote: >> On 02/02/2014 10:40 AM, Masami Hiramatsu wrote: >>> (2014/02/01 21:17), Chen Gang wrote: >>>> When CONFIG_KRETPROBES disabled, cleanup_rp_inst() is useless too. It >>>> is only called by unregister_kretprobes() which is in CONFIG_KRETPROBES >>>> enabled area. >>>> >>>> The related warning (allmodconfig under avr32): >>>> >>>> kernel/kprobes.c:1181: warning: 'cleanup_rp_inst' defined but not used >>> >>> This patch itself looks good to me. >>> And it seems that not only the cleanup_rp_inst, but also other >>> kretprobe related functions should be moved (free_rp_inst,etc) >>> >> >> OK, thanks, need/should I check them again and send patch v2 for them? > > Yes, I'm happy to review it :) > > Thank you! > I will/should finish in these days (within 2014-02-07). Thanks. -- Chen Gang Open, share and attitude like air, water and life which God blessed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/