Message-ID: <3DC3A9C0.7979C276@digeo.com>
Date: Sat, 02 Nov 2002 02:32:32 -0800
From: Andrew Morton <akpm@digeo.com>
MIME-Version: 1.0
To: Akira Tsukamoto <at541@columbia.edu>
CC: linux-kernel@vger.kernel.org, Hirokazu Takahashi <taka@valinux.co.jp>
Subject: Re: [PATCH] 2/2 2.5.45 cleanup & add original copy_ro/from_user
References: <20021102025838.220E.AT541@columbia.edu>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1275
Lines: 28

Akira Tsukamoto wrote:
> 
> This consists mainly of the optimized copy routine for PIII/P4.
> 
> It is basically identical to what was introduced in 2.5.45.

But you've inlined them again.  Your patches increase my kernel
size by 17 kbytes, which is larger than my entire Layer 1 instruction
cache!

I'd prefer that we have these functions in .c, and laid out with
a minimum of C tricks.  Because more work needs to be done on the
memory copy functions, and doing that in header files is a pain.
(That is, using the movnta instructions for well-aligned copies
and clears so that we don't read the destination memory while overwriting
it).

Hopefully, yes, we can end up removing the runtime-selectable alignment
mask.  I left that in at present because it provides the infrastructure
for making other runtime-selectable decisions about how to perform
copies and clears.  Distributors like to be able to ship a minimum
number of kernels (say, just a PII-compiled kernel) and we want those
to run as well as possible on PIII and P4.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/