Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Sat, 2 Nov 2002 06:58:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Sat, 2 Nov 2002 06:58:26 -0500 Received: from pop018pub.verizon.net ([206.46.170.212]:26107 "EHLO pop018.verizon.net") by vger.kernel.org with ESMTP id ; Sat, 2 Nov 2002 06:58:25 -0500 Date: Sat, 02 Nov 2002 06:04:20 -0500 From: Akira Tsukamoto To: Andi Kleen Subject: Re: [PATCH] 1/2 2.5.45 cleanup & add original copy_ro/from_user Cc: linux-kernel@vger.kernel.org In-Reply-To: References: <20021102024957.220C.AT541@columbia.edu.suse.lists.linux.kernel> Message-Id: <20021102055614.0327.AT541@columbia.edu> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.05.06 X-Authentication-Info: Submitted using SMTP AUTH LOGIN at pop018.verizon.net from [138.89.32.225] at Sat, 2 Nov 2002 06:04:48 -0600 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1118 Lines: 30 On 02 Nov 2002 10:58:35 +0100 Andi Kleen mentioned: > Akira Tsukamoto writes: > > > This patch will: > > 1) If it is not X86_MPENTIUMIII or 4, use the original copy routines, > > which does not exist in 2.5.45. > > First you're ignoring Athlon, which also prefers unrolled copies. > > The old user copy functions should then only used when not optimizing for > modern cpus, but not when the minimum level is 386. And perhaps when > CONFIG_SMALL is defined. Yes, it is ignoring Athlon because my patch is basically just clean up and not changing anything. If you read the 2.5.45, you will see *2.5.45* is also ignoring Athlon and not using unrolled copies. I am working on optimized version for AMD, go over on this patch. But thank you for your comment, I will consider using CONFIG_SMALL for putting all the old stuff in it. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/