Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754196AbaBDNgy (ORCPT ); Tue, 4 Feb 2014 08:36:54 -0500 Received: from smtp-out-089.synserver.de ([212.40.185.89]:1098 "EHLO smtp-out-089.synserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753796AbaBDNgv (ORCPT ); Tue, 4 Feb 2014 08:36:51 -0500 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 18705 Message-ID: <52F0ECF2.9070102@metafoo.de> Date: Tue, 04 Feb 2014 14:36:50 +0100 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 MIME-Version: 1.0 To: Mark Brown CC: Jean-Francois Moine , alsa-devel@alsa-project.org, Russell King - ARM Linux , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Clark , Dave Airlie , linux-arm-kernel@lists.infradead.org Subject: Re: [alsa-devel] [PATCH v3 2/5] ASoC: tda998x: add a codec driver for the TDA998x References: <20140204133014.GA22609@sirena.org.uk> In-Reply-To: <20140204133014.GA22609@sirena.org.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/04/2014 02:30 PM, Mark Brown wrote: [...] > > What does this actually do? No information is being passed in to the > core function here, not even any information on if it's starting or > stopping. Looking at the rest of the code I can't help thinking it > might be clearer to inline this possibly with a lookup helper, the code > is very small and the lack of parameters makes it hard to follow. > >> +static const struct snd_soc_dapm_route tda_routes[] = { >> + { "hdmi-out", NULL, "HDMI I2S Playback" }, >> + { "hdmi-out", NULL, "HDMI SPDIF Playback" }, >> +}; > > S/PDIF. Won't this cause issues with the debugfs widget entries? It's fixable by escaping it (replace it by a dash or something) in the debugfs widget filename, but I don't think we do this right now. - Lars -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/