Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932391AbaBDQzv (ORCPT ); Tue, 4 Feb 2014 11:55:51 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:41573 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932336AbaBDQzp (ORCPT ); Tue, 4 Feb 2014 11:55:45 -0500 Message-ID: <52F11B5C.40407@ti.com> Date: Tue, 4 Feb 2014 18:54:52 +0200 From: Ivan Khoronzhuk User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Thomas Gleixner CC: , , , , , , , , , , , , , Subject: Re: [PATCH v4 1/3] clocksource: timer-keystone: introduce clocksource driver for Keystone References: <1391513453-21140-1-git-send-email-ivan.khoronzhuk@ti.com> <1391513453-21140-2-git-send-email-ivan.khoronzhuk@ti.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It was so in v1. But it was decided to use explicit memory barriers, because we're always sure the memory barriers are there and that they're properly documented. Also in this case I don't need to add keystone readl/writel relaxed function variants and to use mixed calls of writel/writel_relaxed functions. See: http://www.spinics.net/lists/arm-kernel/msg294941.html On 02/04/2014 06:24 PM, Thomas Gleixner wrote: > On Tue, 4 Feb 2014, Ivan Khoronzhuk wrote: >> + keystone_timer_writel(off, TCR); >> + /* here we have to be sure the timer has been disabled */ >> + wmb(); > We have explicit writew_relaxed and writew. Why open coding the > barriers? > > Thanks, > > tglx -- Regards, Ivan Khoronzhuk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/