Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754840AbaBDRDY (ORCPT ); Tue, 4 Feb 2014 12:03:24 -0500 Received: from mail-wg0-f48.google.com ([74.125.82.48]:57235 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754702AbaBDRDW (ORCPT ); Tue, 4 Feb 2014 12:03:22 -0500 From: Grant Likely Subject: Re: [RFC PATCH 3/9] of: mtd: add NAND timings retrieval support To: Jason Gunthorpe , boris brezillon Cc: devicetree@vger.kernel.org, Russell King , linux-doc@vger.kernel.org, dev@linux-sunxi.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Rob Landley , Maxime Ripard , David Woodhouse , linux-arm-kernel@lists.infradead.org In-Reply-To: <20140121225740.GP18269@obsidianresearch.com> References: <1389190924-26226-1-git-send-email-b.brezillon@overkiz.com> < 1389190924-26226-4-git-send-email-b.brezillon@overkiz.com> <20140108183418. GA12358@obsidianresearch.com> <52CDA032.3010804@overkiz.com> < 20140108191339.GB12358@obsidianresearch.com> <52CE5F82.6070802@overkiz.com> <20140109173505.GB8899@obsidianresearch.com> <52D6A48D.4080302@overkiz.com> <52D6BF45.80407@overkiz.com> <20140121225740.GP18269@obsidianresearch.com> Date: Tue, 04 Feb 2014 17:02:58 +0000 Message-Id: <20140204170258.3D4FCC4045E@trevor.secretlab.ca> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Jan 2014 15:57:40 -0700, Jason Gunthorpe wrote: > On Wed, Jan 15, 2014 at 06:03:01PM +0100, boris brezillon wrote: > > > >>Pick a mode value that fits all the parameters of the connected > > >>non-ONFI flash. > > >> > > >>This would be instead of defining each parameter > > >>individually.. Provide some helpers to convert from a onfi mode number > > >>to all the onfi defined timing parameters so that drivers can > > >>configure the HW.. > > > > > >Are you suggesting we should provide a function that converts these > > >modes into a nand_timings struct, or just use the timing modes and > > >let the NAND controller drivers configure its IP accordingly ? > > Either seems reasonable to me, but passing the ONFI mode directly from > the NAND core to the driver seems a little safer.. I agree here. There are a lot of parameters being defined. If it can be boiled down to an ONFI mode that will make for a much more robust binding. Far fewer things to get wrong. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/