Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754782AbaBDSAO (ORCPT ); Tue, 4 Feb 2014 13:00:14 -0500 Received: from mail-ve0-f180.google.com ([209.85.128.180]:41800 "EHLO mail-ve0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752125AbaBDSAM (ORCPT ); Tue, 4 Feb 2014 13:00:12 -0500 MIME-Version: 1.0 In-Reply-To: References: <52ee2ee736e00_2c3211fc86c5851f@209.249.196.67.mail> <20140202160512.GA4946@redhat.com> <201402021807.37772.s.L-H@gmx.de> <52EFCC66.9020304@lwfinger.net> <20140203201228.GE26722@mwanda> Date: Tue, 4 Feb 2014 10:00:11 -0800 X-Google-Sender-Auth: mmQUZK88Xj6zn9tMv9TTsSi0roQ Message-ID: Subject: Re: rtl8821ae. From: Linus Torvalds To: Andrea Merello Cc: Dan Carpenter , Larry Finger , Stefan Lippers-Hollmann , Dave Jones , Greg Kroah-Hartman , Linux Wireless List , Linux Kernel , Linux Driver Project Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 3, 2014 at 6:22 PM, Andrea Merello wrote: > Right now I have merged rtl8187se support in rtl8180 driver. But I must > admit that I ever been in doubt about whether to produce a separate driver > rather than going on merging. If you've already merged them, and you think it works, keep it that way. I was just saying that merging drivers isn't necessarily always the right thing to do, and can be painful as hell. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/