Message-ID: <1391548648.2538.32.camel@joe-AO722>
Subject: Re: [Patch v5 1/2] dmaengine: add Qualcomm BAM dma driver
From: Joe Perches <joe@perches.com>
To: Andy Gross <agross@codeaurora.org>
Cc: Vinod Koul <vinod.koul@intel.com>, Dan Williams <dan.j.williams@intel.com>,
        dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-arm-msm@vger.kernel.org
Date: Tue, 04 Feb 2014 13:17:28 -0800
In-Reply-To: <1391546556-27702-2-git-send-email-agross@codeaurora.org>
References: <1391546556-27702-1-git-send-email-agross@codeaurora.org>
	 <1391546556-27702-2-git-send-email-agross@codeaurora.org>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Tue, 2014-02-04 at 14:42 -0600, Andy Gross wrote:
> Add the DMA engine driver for the QCOM Bus Access Manager (BAM) DMA controller
> found in the MSM 8x74 platforms.

trivia: fixable later.

> diff --git a/drivers/dma/qcom_bam_dma.c b/drivers/dma/qcom_bam_dma.c
[]
> +	/* allocate enough room to accomodate the number of entries */
> +	async_desc = kzalloc(sizeof(*async_desc) +
> +			(sg_len * sizeof(struct bam_desc_hw)), GFP_NOWAIT);
> +
> +	if (!async_desc) {
> +		dev_err(bdev->dev, "failed to allocate async descriptor\n");

Unnecessary OOM message as generic alloc has an
OOM message with a dump_stack();

> +static int bam_dma_probe(struct platform_device *pdev)
> +{
[]
> +	ret = clk_prepare_enable(bdev->bamclk);
> +	if (ret) {
> +		dev_err(bdev->dev, "failed to prepare/enable clock");

Missing terminating \n newline


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/