Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935521AbaBDWSy (ORCPT ); Tue, 4 Feb 2014 17:18:54 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:57893 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934246AbaBDWSu (ORCPT ); Tue, 4 Feb 2014 17:18:50 -0500 Date: Tue, 4 Feb 2014 14:18:49 -0800 From: Andrew Morton To: Sergey Senozhatsky Cc: Minchan Kim , Jerome Marchand , Nitin Gupta , linux-kernel@vger.kernel.org Subject: Re: [PATCHv3 6/8] zram: report failed read and write stats Message-Id: <20140204141849.d530625a13e80708446ac426@linux-foundation.org> In-Reply-To: <1389877936-15543-7-git-send-email-sergey.senozhatsky@gmail.com> References: <1389877936-15543-1-git-send-email-sergey.senozhatsky@gmail.com> <1389877936-15543-7-git-send-email-sergey.senozhatsky@gmail.com> X-Mailer: Sylpheed 3.2.0beta5 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Jan 2014 16:12:14 +0300 Sergey Senozhatsky wrote: > zram accounted but did not report numbers of failed read > and write queries. make these stats available as failed_reads > and failed_writes attrs. > > Acked-by: Minchan Kim > Acked-by: Jerome Marchand > Signed-off-by: Sergey Senozhatsky > --- > drivers/block/zram/zram_drv.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c > index e7102f1..9d67fbf 100644 > --- a/drivers/block/zram/zram_drv.c > +++ b/drivers/block/zram/zram_drv.c > @@ -728,6 +728,8 @@ static DEVICE_ATTR(mem_used_total, S_IRUGO, mem_used_total_show, NULL); > > ZRAM_ATTR_RO(num_reads); > ZRAM_ATTR_RO(num_writes); > +ZRAM_ATTR_RO(failed_reads); > +ZRAM_ATTR_RO(failed_writes); > ZRAM_ATTR_RO(invalid_io); > ZRAM_ATTR_RO(notify_free); > ZRAM_ATTR_RO(zero_pages); > @@ -739,6 +741,8 @@ static struct attribute *zram_disk_attrs[] = { > &dev_attr_reset.attr, > &dev_attr_num_reads.attr, > &dev_attr_num_writes.attr, > + &dev_attr_failed_reads.attr, > + &dev_attr_failed_writes.attr, > &dev_attr_invalid_io.attr, > &dev_attr_notify_free.attr, > &dev_attr_zero_pages.attr, Documentation/blockdev/zram.txt and Documentation/ABI/testing/sysfs-block-zram need updating... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/