Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933127AbaBDX76 (ORCPT ); Tue, 4 Feb 2014 18:59:58 -0500 Received: from smtp.codeaurora.org ([198.145.11.231]:37502 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932086AbaBDX75 (ORCPT ); Tue, 4 Feb 2014 18:59:57 -0500 Date: Tue, 4 Feb 2014 15:59:55 -0800 From: Stephen Boyd To: Kumar Gala Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Daniel Lezcano Subject: Re: [PATCH v2 2/5] clocksource: qcom: Move clocksource code out of mach-msm Message-ID: <20140204235955.GF20528@codeaurora.org> References: <1391553532-27001-1-git-send-email-galak@codeaurora.org> <1391553532-27001-3-git-send-email-galak@codeaurora.org> <20140204230956.GE20528@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/04, Kumar Gala wrote: > > On Feb 4, 2014, at 5:09 PM, Stephen Boyd wrote: > > > On 02/04, Kumar Gala wrote: > >> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > >> index cd6950f..81caa16 100644 > >> --- a/drivers/clocksource/Kconfig > >> +++ b/drivers/clocksource/Kconfig > >> @@ -140,3 +140,7 @@ config VF_PIT_TIMER > >> bool > >> help > >> Support for Period Interrupt Timer on Freescale Vybrid Family SoCs. > >> + > >> +config CLKSRC_QCOM > >> + bool > >> + depends on ARCH_MSM > > > > It would be a a little less noisy if you left this as MSM_TIMER > > (msm is all over the code in that file anyway). Also, why do we > > care about depending on ARCH_MSM here? This is a hidden Kconfig > > option anyway. > > I will drop the depends, but not sure what point in leaving this as MSM_TIMER. > Less changes to the Kconfig files if you do that. It's a minor thing. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/