Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751539AbaBEFaz (ORCPT ); Wed, 5 Feb 2014 00:30:55 -0500 Received: from mail-ob0-f179.google.com ([209.85.214.179]:62771 "EHLO mail-ob0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750775AbaBEFax (ORCPT ); Wed, 5 Feb 2014 00:30:53 -0500 MIME-Version: 1.0 In-Reply-To: <20140205051730.GA3911@beef> References: <1391570096-2932-1-git-send-email-mranostay@gmail.com> <20140205044335.GA2172@beef> <20140205051730.GA3911@beef> Date: Tue, 4 Feb 2014 21:30:52 -0800 Message-ID: Subject: Re: [PATCH v4 1/2] iio:as3935: Add DT binding docs for AS3935 driver From: Matt Ranostay To: Matt Porter Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, Pantelis Antoniou Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 4, 2014 at 9:17 PM, Matt Porter wrote: > On Tue, Feb 04, 2014 at 08:52:26PM -0800, Matt Ranostay Matt Ranostay wrote: >> On Tue, Feb 4, 2014 at 8:43 PM, Matt Porter wrote: >> > On Tue, Feb 04, 2014 at 07:14:55PM -0800, Matt Ranostay Matt Ranostay wrote: >> >> Document compatible string, required and optional DT properties for >> >> AS3935 chipset driver. >> >> >> >> Signed-off-by: Matt Ranostay >> >> --- >> >> .../devicetree/bindings/iio/proximity/as3935.txt | 25 ++++++++++++++++++++++ >> >> 1 file changed, 25 insertions(+) >> >> create mode 100644 Documentation/devicetree/bindings/iio/proximity/as3935.txt >> >> >> >> diff --git a/Documentation/devicetree/bindings/iio/proximity/as3935.txt b/Documentation/devicetree/bindings/iio/proximity/as3935.txt >> >> new file mode 100644 >> >> index 0000000..7e117cd >> >> --- /dev/null >> >> +++ b/Documentation/devicetree/bindings/iio/proximity/as3935.txt >> >> @@ -0,0 +1,25 @@ >> >> +Austrian Microsystems AS3935 Franklin lightning sensor device driver >> >> + >> >> +Required properties: >> >> + - compatible: must be "ams,as3935" >> > >> > Change this to "amstaos,as3935" >> > >> > amstaos (AMS bought Taos) is already a registered vendor prefix in >> > vendor-prefixes.txt >> > >> >> + - reg: SPI chip select number for the device >> >> + - spi-cpha: SPI Mode 1 >> > >> > When using generic binding properties, please reference the binding >> > being used. Like: >> > >> > - spi-cpha: SPI Mode 1. Refer to spi/spi-bus.txt for generic SPI >> > slave node bindings. >> > >> Noted. >> >> >> + - interrupt-parent : should be the phandle for the interrupt controller >> >> + - interrupts : interrupt mapping for GPIO IRQ >> > >> > Refer to interrupt-controller/interrupts.txt for generic >> > interrupt client node bindings. >> > >> Noted. >> >> >> + >> >> +Optional properties: >> >> + - ams,tune-cap: Calibration tuning capacitor stepping value 0 - 15. >> >> + Range of 0 to 120 pF, 8pF steps. This will require using the >> >> + calibration data from the manufacturer. >> >> + >> >> + >> >> +Example: >> >> + >> >> +as3935@0 { >> >> + compatible = "ams,as3935"; >> >> + reg = <0>; >> >> + spi-cpha; >> >> + interrupt-parent = <&gpio1>; >> >> + interrupts = <16 1>; >> >> + ams,tune-cap = /bits/ 8 <10>; >> > >> > What is this? Why not just ams,tune-cap = <10>; ? >> > >> > It's a value between 0-15, right? >> >> Correct but it is using of_property_read_u8() so that requires the >> /bits/ statement. >> Should this just be a u32 value? > > Do you really need a u8? If not just read_u32() into an int and keep > this syntax simple. Just me different it seems :P. Will fix in next version waiting for Peter's and Jonathan's input on the rest of the code first. > > -Matt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/