Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751446AbaBEJEO (ORCPT ); Wed, 5 Feb 2014 04:04:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:22302 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbaBEJEI (ORCPT ); Wed, 5 Feb 2014 04:04:08 -0500 Date: Wed, 5 Feb 2014 10:03:39 +0100 From: Jiri Olsa To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, Corey Ashford , Frederic Weisbecker , Ingo Molnar , Namhyung Kim , Paul Mackerras , Peter Zijlstra , Arnaldo Carvalho de Melo , David Ahern Subject: Re: [PATCH] perf tools: Handle PERF_RECORD_HEADER_EVENT_TYPE properly Message-ID: <20140205090339.GB1201@krava.brq.redhat.com> References: <1391524668-12546-1-git-send-email-jolsa@redhat.com> <20140205055552.GD30094@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140205055552.GD30094@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 05, 2014 at 06:55:52AM +0100, Ingo Molnar wrote: > > * Jiri Olsa wrote: > > > We removed event types from data file in following commits: > > 6065210 perf tools: Remove event types framework completely > > 44b3c57 perf tools: Remove event types from perf data file > > > > We no longer need this information, because we can get it > > directly from tracepoints. > > > > But we still need to handle PERF_RECORD_HEADER_EVENT_TYPE > > event for the sake of old perf data files created in pipe > > mode like: > > > > $ perf.3.4 record -o - foo >perf.data > > $ perf.312 report -i - < perf.data > > > > Reported-by: Stephane Eranian > > Signed-off-by: Jiri Olsa > > Cc: Corey Ashford > > Cc: Frederic Weisbecker > > Cc: Ingo Molnar > > Cc: Namhyung Kim > > Cc: Paul Mackerras > > Cc: Peter Zijlstra > > Cc: Arnaldo Carvalho de Melo > > Cc: David Ahern > > --- > > tools/perf/util/session.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c > > index 0b39a48..5da6ce7 100644 > > --- a/tools/perf/util/session.c > > +++ b/tools/perf/util/session.c > > @@ -1008,6 +1008,12 @@ static int perf_session__process_user_event(struct perf_session *session, union > > if (err == 0) > > perf_session__set_id_hdr_size(session); > > return err; > > + case PERF_RECORD_HEADER_EVENT_TYPE: > > + /* > > + * Depreceated, but we need to handle it for sake > > + * of old data files create in pipe mode. > > + */ > > Two small speling nits: > > s/Depreceated > /Deprecated > > s/create > /created > > Ack otherwise. > > Thanks, > > Ingo ugh, my spell checker sux.. ;-\ acme, beer for each correction? ;-) thanks, jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/