Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752403AbaBEOe1 (ORCPT ); Wed, 5 Feb 2014 09:34:27 -0500 Received: from mail-ob0-f178.google.com ([209.85.214.178]:59383 "EHLO mail-ob0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752337AbaBEOeZ (ORCPT ); Wed, 5 Feb 2014 09:34:25 -0500 MIME-Version: 1.0 In-Reply-To: <1391529538-21685-15-git-send-email-ulf.hansson@linaro.org> References: <1391529538-21685-1-git-send-email-ulf.hansson@linaro.org> <1391529538-21685-15-git-send-email-ulf.hansson@linaro.org> Date: Wed, 5 Feb 2014 15:34:24 +0100 Message-ID: Subject: Re: [PATCH 14/17] i2c: nomadik: Fixup deployment of runtime PM From: Linus Walleij To: Ulf Hansson Cc: Russell King , "linux-arm-kernel@lists.infradead.org" , Alessandro Rubini , Wolfram Sang , Chris Ball , Mark Brown , "linux-kernel@vger.kernel.org" , "linux-i2c@vger.kernel.org" , linux-spi@vger.kernel.org, "linux-mmc@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 4, 2014 at 4:58 PM, Ulf Hansson wrote: > Since the device is active while a successful probe has been completed, > the reference counting for the clock will be screwed up and never reach > zero. > > The issue is resolved by implementing runtime PM callbacks and let them > handle the resources accordingly, including the clock. > > Cc: Alessandro Rubini > Cc: Linus Walleij > Cc: Wolfram Sang > Signed-off-by: Ulf Hansson Hm do I read it right as patch 13 breaks runtime PM by leaving the device active after probe() and this patch 14 fixes it again? Maybe these two patches should be squashed then. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/