Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753045AbaBEQjh (ORCPT ); Wed, 5 Feb 2014 11:39:37 -0500 Received: from mail-qc0-f179.google.com ([209.85.216.179]:65006 "EHLO mail-qc0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752681AbaBEQjf convert rfc822-to-8bit (ORCPT ); Wed, 5 Feb 2014 11:39:35 -0500 MIME-Version: 1.0 In-Reply-To: <20140205163117.GA15996@earth.universe> References: <1391603582-11371-1-git-send-email-sre@debian.org> <20140205163117.GA15996@earth.universe> From: =?UTF-8?Q?Pali_Roh=C3=A1r?= Date: Wed, 5 Feb 2014 17:38:54 +0100 Message-ID: Subject: Re: [PATCH] ARM: OMAP2+: Add support for thumb mode on DT booted N900 To: Sebastian Reichel Cc: Tony Lindgren , Linux OMAP Mailing List , LKML , freemangordon@abv.bg Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2014-02-05 Sebastian Reichel : > Hi Pali, > > On Wed, Feb 05, 2014 at 02:12:56PM +0100, Pali Rohár wrote: >> 1) Why are you using if (IS_ENABLED(CONFIG_ARM_ERRATA_430973)) instead #ifdef ? > > This is the preferred kernel style as far as I know. > Ok. >> 2) Why do you not write warning or info when omap type is not >> OMAP2_DEVICE_TYPE_SEC (e.g qemu) ? > > I assumed, that the workaround is not needed for this device type. > That rx51 secure call must not be called on non secure devices (e.g. qemu), because it cause kernel crash. So I thought that kernel should write something like secure call is disabled on that device types. Kernel code for errata 430973 will update ibe bit for non secure devices. > I just added the warning for missing CONFIG_ARM_ERRATA_430973, > because its very likely a misconfigured kernel. > > -- Sebastian Yes, it can be misconfigured kernel, but if you do not have any thumb binary (like stock Maemo 5 system), then it is safe and OK. -- Pali Rohár pali.rohar@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/