Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753578AbaBESBr (ORCPT ); Wed, 5 Feb 2014 13:01:47 -0500 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:44744 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753175AbaBESBq (ORCPT ); Wed, 5 Feb 2014 13:01:46 -0500 Date: Wed, 5 Feb 2014 18:01:16 +0000 From: Will Deacon To: Leif Lindholm Cc: "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-efi@vger.kernel.org" , "patches@linaro.org" Subject: Re: [PATCH 02/22] arm: add new asm macro update_sctlr Message-ID: <20140205180115.GE28140@mudshark.cambridge.arm.com> References: <1391619853-10601-1-git-send-email-leif.lindholm@linaro.org> <1391619853-10601-3-git-send-email-leif.lindholm@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1391619853-10601-3-git-send-email-leif.lindholm@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 05, 2014 at 05:03:53PM +0000, Leif Lindholm wrote: > A new macro for setting/clearing bits in the SCTLR. > > Signed-off-by: Leif Lindholm > Suggested-by: Will Deacon > Cc: Will Deacon > --- > arch/arm/include/asm/assembler.h | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) Acked-by: Will Deacon (although really minor comment below) > diff --git a/arch/arm/include/asm/assembler.h b/arch/arm/include/asm/assembler.h > index 5c22851..e8ca24b 100644 > --- a/arch/arm/include/asm/assembler.h > +++ b/arch/arm/include/asm/assembler.h > @@ -383,4 +383,18 @@ THUMB( orr \reg , \reg , #PSR_T_BIT ) > #endif > .endm > > +#ifdef CONFIG_CPU_CP15 > +/* Macro for setting/clearing bits in sctlr */ > + .macro update_sctlr, tmp:req, set=, clear= > + mrc p15, 0, \tmp, c1, c0, 0 > + .ifnc \set, > + orr \tmp, \set I'd prefer the 3-arg form here for consistency (with this macro and the rest of the file). Will -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/