Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933221AbaBEUnP (ORCPT ); Wed, 5 Feb 2014 15:43:15 -0500 Received: from mail-qa0-f43.google.com ([209.85.216.43]:48079 "EHLO mail-qa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755326AbaBEUnL convert rfc822-to-8bit (ORCPT ); Wed, 5 Feb 2014 15:43:11 -0500 MIME-Version: 1.0 In-Reply-To: <20140205171729.GA17974@earth.universe> References: <1391603582-11371-1-git-send-email-sre@debian.org> <20140205163117.GA15996@earth.universe> <20140205171729.GA17974@earth.universe> From: =?UTF-8?Q?Pali_Roh=C3=A1r?= Date: Wed, 5 Feb 2014 21:42:30 +0100 Message-ID: Subject: Re: [PATCH] ARM: OMAP2+: Add support for thumb mode on DT booted N900 To: Sebastian Reichel Cc: Tony Lindgren , Linux OMAP Mailing List , LKML , freemangordon@abv.bg Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2014-02-05 Sebastian Reichel : > Hi, > > On Wed, Feb 05, 2014 at 05:38:54PM +0100, Pali Rohár wrote: >> > I assumed, that the workaround is not needed for this device type. >> >> That rx51 secure call must not be called on non secure devices (e.g. >> qemu), because it cause kernel crash. So I thought that kernel should >> write something like secure call is disabled on that device types. >> Kernel code for errata 430973 will update ibe bit for non secure >> devices. > > Do you see any advantage in having that message? > Consistency. Print message 1) only if secure rx51 smc instruction is called or 2) print message always (also if smc is not called). With that patch message is printed (enabled/disabled) only if device is rx51 and device type is HS. For information it is also good to know that in qemu that special secure smc instruction was not called. -- Pali Rohár pali.rohar@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/