Date: Wed, 5 Feb 2014 22:58:28 +0200 (EET)
From: Julian Anastasov <ja@ssi.bg>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org,
        Mathias Krause <minipli@googlemail.com>,
        Wensong Zhang <wensong@linux-vs.org>,
        Simon Horman <horms@verge.net.au>,
        "David S. Miller" <davem@davemloft.net>
Subject: Re: [v2.6.34-stable 032/213] ipvs: fix info leak in
 getsockopt(IP_VS_SO_GET_TIMEOUT)
In-Reply-To: <alpine.LFD.2.11.1402052234230.1496@ja.home.ssi.bg>
Message-ID: <alpine.LFD.2.11.1402052248170.1962@ja.home.ssi.bg>
References: <1391630568-49251-1-git-send-email-paul.gortmaker@windriver.com> <1391630568-49251-33-git-send-email-paul.gortmaker@windriver.com> <alpine.LFD.2.11.1402052234230.1496@ja.home.ssi.bg>
User-Agent: Alpine 2.11 (LFD 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org


	Hello,

On Wed, 5 Feb 2014, Julian Anastasov wrote:

> On Wed, 5 Feb 2014, Paul Gortmaker wrote:
> 
> > From: Mathias Krause <minipli@googlemail.com>
> > 
> >                    -------------------
> >     This is a commit scheduled for the next v2.6.34 longterm release.
> >     http://git.kernel.org/?p=linux/kernel/git/paulg/longterm-queue-2.6.34.git
> >     If you see a problem with using this for longterm, please comment.
> >                    -------------------
> > 
> > commit 2d8a041b7bfe1097af21441cb77d6af95f4f4680 upstream.
> > 
> > If at least one of CONFIG_IP_VS_PROTO_TCP or CONFIG_IP_VS_PROTO_UDP is
> > not set, __ip_vs_get_timeouts() does not fully initialize the structure
> > that gets copied to userland and that for leaks up to 12 bytes of kernel
> > stack. Add an explicit memset(0) before passing the structure to
> > __ip_vs_get_timeouts() to avoid the info leak.
> 
> 	I guess, this patch is not needed after commit
> "ipvs: initialize returned data in do_ip_vs_get_ctl" because
> the memset is already moved into __ip_vs_get_timeouts().

	Sorry, I thought this patch comes after commit
b61a602ee6730150f4d0df730d9312ac4d820ceb
("ipvs: initialize returned data in do_ip_vs_get_ctl")
but it looks like it is ok with this single change,
sorry for the noise!

Regards

--
Julian Anastasov <ja@ssi.bg>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/