Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755844AbaBFJcr (ORCPT ); Thu, 6 Feb 2014 04:32:47 -0500 Received: from cantor2.suse.de ([195.135.220.15]:35882 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755355AbaBFJcp (ORCPT ); Thu, 6 Feb 2014 04:32:45 -0500 Date: Thu, 06 Feb 2014 10:32:43 +0100 Message-ID: From: Takashi Iwai To: Jean-Francois Moine Cc: perex@perex.cz, lars@metafoo.de, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: pcm: export some constraint functions In-Reply-To: <20140206091402.5F54D940120@smtp1-g21.free.fr> References: <20140206091402.5F54D940120@smtp1-g21.free.fr> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 6 Feb 2014 09:41:48 +0100, Jean-Francois Moine wrote: > > The functions snd_pcm_hw_constraint_mask() and > snd_pcm_hw_constraint_mask64() are needed to add audio constraints > to substreams at open/startup time. > This patch makes them available to ALSA modules. I guess it's a part of series, right? If so, feel free to take my ack for this patch. Acked-by: Takashi Iwai BTW, we should use EXPORT_SYMBOL_GPL() for new entries in general. OTOH, it won't match with others in the same file, and it may look inconsistent. So, I don't mind either way. thanks, Takashi > > Signed-off-by: Jean-Francois Moine > --- > sound/core/pcm_lib.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c > index a210467..aea4972 100644 > --- a/sound/core/pcm_lib.c > +++ b/sound/core/pcm_lib.c > @@ -1219,6 +1219,7 @@ int snd_pcm_hw_constraint_mask(struct snd_pcm_runtime *runtime, snd_pcm_hw_param > return -EINVAL; > return 0; > } > +EXPORT_SYMBOL(snd_pcm_hw_constraint_mask); > > /** > * snd_pcm_hw_constraint_mask64 - apply the given bitmap mask constraint > @@ -1242,6 +1243,7 @@ int snd_pcm_hw_constraint_mask64(struct snd_pcm_runtime *runtime, snd_pcm_hw_par > return -EINVAL; > return 0; > } > +EXPORT_SYMBOL(snd_pcm_hw_constraint_mask64); > > /** > * snd_pcm_hw_constraint_integer - apply an integer constraint to an interval > -- > 1.9.rc1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/