Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753920AbaBFVvT (ORCPT ); Thu, 6 Feb 2014 16:51:19 -0500 Received: from mail-la0-f50.google.com ([209.85.215.50]:52916 "EHLO mail-la0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751637AbaBFVvS (ORCPT ); Thu, 6 Feb 2014 16:51:18 -0500 MIME-Version: 1.0 In-Reply-To: <52F3FFBC.1010505@redhat.com> References: <1391685000-7346-1-git-send-email-mq@suse.cz> <52F3FFBC.1010505@redhat.com> Date: Thu, 6 Feb 2014 13:51:16 -0800 Message-ID: Subject: Re: [PATCH] inet: defines IPPROTO_* needed for module alias generation From: Cong Wang To: "Carlos O'Donell" Cc: Jan Moskyto Matejka , "David S. Miller" , netdev , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 6, 2014 at 1:33 PM, Carlos O'Donell wrote: > On 02/06/2014 06:10 AM, Jan Moskyto Matejka wrote: >> Reverting this change back to define's to fix the aliases. >> >> modinfo mip6 (before this change) >> alias: xfrm-type-10-IPPROTO_DSTOPTS >> alias: xfrm-type-10-IPPROTO_ROUTING >> >> modinfo mip6 (after this change) >> alias: xfrm-type-10-43 >> alias: xfrm-type-10-60 > > Instead of reverting these changes I suggest someone fix > whatever is processing that information. It is stringfy by c preprocessor. enum should be processed after preprocessing, therefore fails to be converted to it real value at preprocessing stage. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/