Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751400AbaBGBSC (ORCPT ); Thu, 6 Feb 2014 20:18:02 -0500 Received: from mail-qa0-f54.google.com ([209.85.216.54]:51868 "EHLO mail-qa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750704AbaBGBR7 (ORCPT ); Thu, 6 Feb 2014 20:17:59 -0500 Date: Fri, 7 Feb 2014 01:17:57 +0000 (GMT) From: Nicolas Pitre To: Preeti U Murthy cc: Daniel Lezcano , Benjamin Herrenschmidt , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , "Rafael J. Wysocki" , LKML , Linux ARM Kernel ML , linuxppc-dev@lists.ozlabs.org, "linux-pm@vger.kernel.org" , Lists linaro-kernel Subject: Re: [PATCH 1/2] PPC: powernv: remove redundant cpuidle_idle_call() In-Reply-To: <52F3BCFE.3010703@linux.vnet.ibm.com> Message-ID: References: <1391696188-14540-1-git-send-email-nicolas.pitre@linaro.org> <52F3BCFE.3010703@linux.vnet.ibm.com> User-Agent: Alpine 2.11 (LFD 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 6 Feb 2014, Preeti U Murthy wrote: > Hi Daniel, > > On 02/06/2014 09:55 PM, Daniel Lezcano wrote: > > Hi Nico, > > > > > > On 6 February 2014 14:16, Nicolas Pitre wrote: > > > >> The core idle loop now takes care of it. > >> > >> Signed-off-by: Nicolas Pitre > >> --- > >> arch/powerpc/platforms/powernv/setup.c | 13 +------------ > >> 1 file changed, 1 insertion(+), 12 deletions(-) > >> > >> diff --git a/arch/powerpc/platforms/powernv/setup.c > >> b/arch/powerpc/platforms/powernv/setup.c > >> index 21166f65c9..a932feb290 100644 > >> --- a/arch/powerpc/platforms/powernv/setup.c > >> +++ b/arch/powerpc/platforms/powernv/setup.c > >> @@ -26,7 +26,6 @@ > >> #include > >> #include > >> #include > >> -#include > >> > >> #include > >> #include > >> @@ -217,16 +216,6 @@ static int __init pnv_probe(void) > >> return 1; > >> } > >> > >> -void powernv_idle(void) > >> -{ > >> - /* Hook to cpuidle framework if available, else > >> - * call on default platform idle code > >> - */ > >> - if (cpuidle_idle_call()) { > >> - power7_idle(); > >> - } > >> > > > > The cpuidle_idle_call is called from arch_cpu_idle in > > arch/powerpc/kernel/idle.c between a ppc64_runlatch_off|on section. > > Shouldn't the cpuidle-powernv driver call these functions when entering > > idle ? > > Yes they should, I will send out a patch that does that ontop of this. > There have been cpuidle driver cleanups for powernv and pseries in this > merge window. While no change would be required in the pseries cpuidle > driver as a result of Nicolas's cleanup, we would need to add the > ppc64_runlatch_on and off functions before and after the entry into the > powernv idle states. What about creating arch_cpu_idle_enter() and arch_cpu_idle_exit() in arch/powerpc/kernel/idle.c and calling ppc64_runlatch_off() and ppc64_runlatch_on() respectively from there instead? Would that work? That would make the idle consolidation much easier afterwards. Nicolas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/