Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751658AbaBGFJu (ORCPT ); Fri, 7 Feb 2014 00:09:50 -0500 Received: from LGEMRELSE1Q.lge.com ([156.147.1.111]:52271 "EHLO LGEMRELSE1Q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750711AbaBGFIu (ORCPT ); Fri, 7 Feb 2014 00:08:50 -0500 X-AuditID: 9c93016f-b7b0cae0000024a7-3a-52f46a5fb0e5 From: Joonsoo Kim To: Andrew Morton Cc: Mel Gorman , Vlastimil Babka , Joonsoo Kim , Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Joonsoo Kim Subject: [PATCH 2/5] mm/compaction: do not call suitable_migration_target() on every page Date: Fri, 7 Feb 2014 14:08:43 +0900 Message-Id: <1391749726-28910-3-git-send-email-iamjoonsoo.kim@lge.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1391749726-28910-1-git-send-email-iamjoonsoo.kim@lge.com> References: <1391749726-28910-1-git-send-email-iamjoonsoo.kim@lge.com> X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org suitable_migration_target() checks that pageblock is suitable for migration target. In isolate_freepages_block(), it is called on every page and this is inefficient. So make it called once per pageblock. suitable_migration_target() also checks if page is highorder or not, but it's criteria for highorder is pageblock order. So calling it once within pageblock range has no problem. Signed-off-by: Joonsoo Kim diff --git a/mm/compaction.c b/mm/compaction.c index bbe1260..0d821a2 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -245,6 +245,7 @@ static unsigned long isolate_freepages_block(struct compact_control *cc, unsigned long nr_strict_required = end_pfn - blockpfn; unsigned long flags; bool locked = false; + bool checked_pageblock = false; cursor = pfn_to_page(blockpfn); @@ -275,8 +276,16 @@ static unsigned long isolate_freepages_block(struct compact_control *cc, break; /* Recheck this is a suitable migration target under lock */ - if (!strict && !suitable_migration_target(page)) - break; + if (!strict && !checked_pageblock) { + /* + * We need to check suitability of pageblock only once + * and this isolate_freepages_block() is called with + * pageblock range, so just check once is sufficient. + */ + checked_pageblock = true; + if (!suitable_migration_target(page)) + break; + } /* Recheck this is a buddy page under lock */ if (!PageBuddy(page)) -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/