Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751198AbaBGHFd (ORCPT ); Fri, 7 Feb 2014 02:05:33 -0500 Received: from e23smtp05.au.ibm.com ([202.81.31.147]:45147 "EHLO e23smtp05.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750708AbaBGHFb (ORCPT ); Fri, 7 Feb 2014 02:05:31 -0500 Message-ID: <52F484D9.6020604@linux.vnet.ibm.com> Date: Fri, 07 Feb 2014 12:31:45 +0530 From: Preeti U Murthy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 MIME-Version: 1.0 To: Nicolas Pitre , Deepthi Dharwar CC: Lists linaro-kernel , "linux-pm@vger.kernel.org" , Peter Zijlstra , Daniel Lezcano , "Rafael J. Wysocki" , LKML , Ingo Molnar , Thomas Gleixner , linuxppc-dev@lists.ozlabs.org, Linux ARM Kernel ML Subject: Re: [PATCH 1/2] PPC: powernv: remove redundant cpuidle_idle_call() References: <1391696188-14540-1-git-send-email-nicolas.pitre@linaro.org> <52F3BCFE.3010703@linux.vnet.ibm.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14020707-1396-0000-0000-00000440E752 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nicolas, Find below the patch that will need to be squashed with this one. This patch is based on the mainline.Adding Deepthi, the author of the patch which introduced the powernv cpuidle driver. Deepthi, do you think the below patch looks right? We do not need to do an explicit local_irq_enable() since we are in the call path of cpuidle driver and that explicitly enables irqs on exit from idle states. On 02/07/2014 06:47 AM, Nicolas Pitre wrote: > On Thu, 6 Feb 2014, Preeti U Murthy wrote: > >> Hi Daniel, >> >> On 02/06/2014 09:55 PM, Daniel Lezcano wrote: >>> Hi Nico, >>> >>> >>> On 6 February 2014 14:16, Nicolas Pitre wrote: >>> >>>> The core idle loop now takes care of it. >>>> >>>> Signed-off-by: Nicolas Pitre >>>> --- >>>> arch/powerpc/platforms/powernv/setup.c | 13 +------------ >>>> 1 file changed, 1 insertion(+), 12 deletions(-) >>>> >>>> diff --git a/arch/powerpc/platforms/powernv/setup.c >>>> b/arch/powerpc/platforms/powernv/setup.c >>>> index 21166f65c9..a932feb290 100644 >>>> --- a/arch/powerpc/platforms/powernv/setup.c >>>> +++ b/arch/powerpc/platforms/powernv/setup.c >>>> @@ -26,7 +26,6 @@ >>>> #include >>>> #include >>>> #include >>>> -#include >>>> >>>> #include >>>> #include >>>> @@ -217,16 +216,6 @@ static int __init pnv_probe(void) >>>> return 1; >>>> } >>>> >>>> -void powernv_idle(void) >>>> -{ >>>> - /* Hook to cpuidle framework if available, else >>>> - * call on default platform idle code >>>> - */ >>>> - if (cpuidle_idle_call()) { >>>> - power7_idle(); >>>> - } >>>> drivers/cpuidle/cpuidle-powernv.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/cpuidle/cpuidle-powernv.c b/drivers/cpuidle/cpuidle-powernv.c index 78fd174..130f081 100644 --- a/drivers/cpuidle/cpuidle-powernv.c +++ b/drivers/cpuidle/cpuidle-powernv.c @@ -31,11 +31,13 @@ static int snooze_loop(struct cpuidle_device *dev, set_thread_flag(TIF_POLLING_NRFLAG); while (!need_resched()) { + ppc64_runlatch_off(); HMT_low(); HMT_very_low(); } HMT_medium(); + ppc64_runlatch_on(); clear_thread_flag(TIF_POLLING_NRFLAG); smp_mb(); return index; @@ -45,7 +47,9 @@ static int nap_loop(struct cpuidle_device *dev, struct cpuidle_driver *drv, int index) { + ppc64_runlatch_off(); power7_idle(); + ppc64_runlatch_on(); return index; } Thanks Regards Preeti U Murthy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/